[GitHub] [hive] kgyrtkirk commented on a change in pull request #2585: HIVE-25448: Invalid partition columns when skew with distinct

[GitBox <gi...@apache.org>]

kgyrtkirk commented on a change in pull request #2585:
URL: https://github.com/apache/hive/pull/2585#discussion_r812739484



##########
File path: ql/src/test/results/clientpositive/llap/autoColumnStats_7.q.out
##########
@@ -56,7 +56,7 @@ STAGE PLANS:
                       key expressions: _col0 (type: string), _col1 (type: string)
                       null sort order: zz
                       sort order: ++
-                      Map-reduce partition columns: _col0 (type: string)
+                      Map-reduce partition columns: _col0 (type: string), _col1 (type: string)

Review comment:
       do you happen to have a directed testcase which were working incorrectly before this patch?
   
   I guess it was returning 3 for distinct in case the rows were in the order of:
   ```
   a | b
   a | a
   a | b
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org