You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by alopresto <gi...@git.apache.org> on 2016/05/25 02:30:19 UTC
[GitHub] nifi pull request: NIFI-1918 Ignored failing test because timing i...
GitHub user alopresto opened a pull request:
https://github.com/apache/nifi/pull/465
NIFI-1918 Ignored failing test because timing is not deterministic an\u2026
\u2026d should not be used in unit test.
I did not delete the test because it is still illustrative in most cases of the relative differences in execution time, but in some scenarios (thread-starved hardware?) the serial execution can finish faster than pooled.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alopresto/nifi NIFI-1918
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/465.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #465
----
commit 402ef3fa0fe21b318c7a9c423b2d8b016ddf58ab
Author: Andy LoPresto <al...@apache.org>
Date: 2016-05-25T02:28:37Z
NIFI-1918 Ignored failing test because timing is not deterministic and should not be used in unit test.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1918 Ignored failing test because timing i...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the pull request:
https://github.com/apache/nifi/pull/465#issuecomment-221458835
LGTM +1, I built and ran the tests, verified this one is skipped. Agree with the @Ignore versus delete for instructional purposes, I also can't think of a good deterministic test but recognize that the serial-faster-than-pooled is possible under the conditions mentioned. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1918 Ignored failing test because timing i...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/465
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---