You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by astroshim <gi...@git.apache.org> on 2017/02/22 02:40:52 UTC
[GitHub] zeppelin pull request #2053: [ZEPPELIN-1964] Layout info is lost after refre...
GitHub user astroshim opened a pull request:
https://github.com/apache/zeppelin/pull/2053
[ZEPPELIN-1964] Layout info is lost after refresh
### What is this PR for?
This PR fixes layout info is lost after refreshing issue.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1964
### How should this be tested?
Please do resize paragraph and then refresh browser.
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1964
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2053.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2053
----
commit 474bdf52f40a9f3e5ec9b7746fd91178b8fb9e39
Author: astroshim <hs...@zepl.com>
Date: 2017-02-22T02:34:50Z
fix layout lost problem
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2053: [ZEPPELIN-1964] Layout info is lost after refresh
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2053
Thanks @astroshim for fixing this!
Tested and it works well like below! LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2053: [ZEPPELIN-1964] Layout info is lost after refresh
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2053
Tested and it works well as expected. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2053: [ZEPPELIN-1964] Layout info is lost after refresh
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2053
Merge into branch-0.7 and master if there are no more comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2053: [ZEPPELIN-1964] Layout info is lost after refre...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2053
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2053: [ZEPPELIN-1964] Layout info is lost after refresh
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2053
I will review and give you feedback soon. Thanks for fixing bug @astroshim!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2053: [ZEPPELIN-1964] Layout info is lost after refresh
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2053
@astroshim This patch just merged into master, but couldn't automatically cherrypicked to branch-0.7 since master's `paragraph.controller.js` is a bit different with branch-0.7's after SPELL is merged. Could you create separated PR based on `branch-0.7` so that this can be included to next 0.7.1 release?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---