You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ilya Pronin <ip...@twopensource.com> on 2018/09/20 21:38:43 UTC
Re: Review Request 68402: Added a test for XFS persistent volume
isolation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68402/#review208813
-----------------------------------------------------------
src/tests/containerizer/xfs_quota_tests.cpp
Lines 505 (patched)
<https://reviews.apache.org/r/68402/#comment293021>
Add the same test with `QuotaPolicy::ENFORCING_ACTIVE`?
src/tests/containerizer/xfs_quota_tests.cpp
Lines 608-610 (patched)
<https://reviews.apache.org/r/68402/#comment293016>
The comment should say "Destroy the volume".
- Ilya Pronin
On Aug. 16, 2018, 4:52 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68402/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2018, 4:52 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, and Jiang Yan Xu.
>
>
> Bugs: MESOS-5158
> https://issues.apache.org/jira/browse/MESOS-5158
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test to ensure that the `disk/xfs` isolator can isolate
> and manage project IDs on a persistent volume.
>
>
> Diffs
> -----
>
> src/tests/containerizer/xfs_quota_tests.cpp 2b3a2e25f5075357f090d47826698e7bb6fdf969
>
>
> Diff: https://reviews.apache.org/r/68402/diff/4/
>
>
> Testing
> -------
>
> sudo make check (Fedora 28)
>
>
> Thanks,
>
> James Peach
>
>