You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Benedict (JIRA)" <ji...@apache.org> on 2015/07/09 18:29:05 UTC
[jira] [Commented] (CASSANDRA-8963) Make OpOrder more intuitive
[ https://issues.apache.org/jira/browse/CASSANDRA-8963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14620792#comment-14620792 ]
Benedict commented on CASSANDRA-8963:
-------------------------------------
So, as it happens, I wrote a refactored version of OpOrder a while back [here|https://github.com/belliottsmith/bes-utils/tree/master/src/bes/concurrent/order]
[~JoshuaMcKenzie]: WDYT of that design? More intuitive?
The {{Op}} objects will also be capable of having debug logic attached. Since the work is minimal, I will port into C* codebase and submit a patch, if it's considered that this is in roughly the correct state.
This will also provide useful features for the work [~beobal] is doing on secondary indexes.
> Make OpOrder more intuitive
> ---------------------------
>
> Key: CASSANDRA-8963
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8963
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Benedict
> Assignee: Benedict
> Priority: Minor
> Fix For: 3.x
>
>
> There has been plenty of feedback about OpOrder being unintuitive. As well as revisiting the naming, I propose to introduce an Action object with RAII (AutoCloseable) protection that should be more obvious to users of the API. We can also then protect this by a Ref instance for use cases where the action lifetime is illdefined, and perhaps also introduce some checks for actions whose lifetimes extend beyond a sensible limit to report those where the object reference is retained.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)