[GitHub] ezelkow1 opened a new pull request #3042: Adding backup file support for the crconfig and tmconfig files in Traffic Monitor

[GitBox <gi...@apache.org>]

ezelkow1 opened a new pull request #3042: Adding backup file support for the crconfig and tmconfig files in Traffic Monitor
URL: https://github.com/apache/trafficcontrol/pull/3042
 
 
   Any time TM receives a valid cr or tm config file it gets written to a backup file on disk. A poller is started with a default of 1 sec (or using file_retry_timeout_ms in the
   
   config file) that will poll the TO url every interval. If the url is unreachable and the backup files exist then TM will fall back to using those backup files for monitoring. The url will then be checked on the next interval and the next time
   TO is available TM will switch back to the url usage.
   
   Along with the file_retry_timeout_ms this also adds crconfig_backup_file and tmconfig_backup_file optional settings to specify backup file locations
   
   On startup we continue to use the new backoff method however after we have reached TrafficOpsFileFallbackRetries amount we then test if the backup files exist and if they do we proceed to the disk based method. This way if TM starts up and TO
   is down it will continue to work as long as it has a valid backup cr and tm config files.
   
   #### Which TC components are affected by this PR?
   
   - [ ] Documentation
   - [ ] Grove
   - [ ] Traffic Analytics
   - [ ] Traffic Monitor
   - [ ] Traffic Ops
   - [ ] Traffic Ops ORT
   - [ ] Traffic Portal
   - [ ] Traffic Router
   - [ ] Traffic Stats
   - [ ] Traffic Vault
   - [ ] Other _________
   
   #### What is the best way to verify this PR?
   
   Test with TO up and down and verify that TM still functions properly using the backup created on disk
   
   #### Check all that apply
   
   - [ ] This PR includes tests
   - [ ] This PR includes documentation updates
   - [ ] This PR includes an update to CHANGELOG.md
   - [ ] This PR includes all required license headers
   - [ ] This PR includes a database migration (ensure that migration sequence is correct)
   - [ ] This PR fixes a serious security flaw. Read more: [www.apache.org/security](http://www.apache.org/security/)
   
   <!--
       Licensed to the Apache Software Foundation (ASF) under one
       or more contributor license agreements.  See the NOTICE file
       distributed with this work for additional information
       regarding copyright ownership.  The ASF licenses this file
       to you under the Apache License, Version 2.0 (the
       "License"); you may not use this file except in compliance
       with the License.  You may obtain a copy of the License at
   
         http://www.apache.org/licenses/LICENSE-2.0
   
       Unless required by applicable law or agreed to in writing,
       software distributed under the License is distributed on an
       "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
       KIND, either express or implied.  See the License for the
       specific language governing permissions and limitations
       under the License.
   -->
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services