You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "MisterRaindrop (via GitHub)" <gi...@apache.org> on 2026/01/28 09:58:51 UTC
[PR] CMake: require Parquet when using system Arrow [iceberg-cpp]
MisterRaindrop opened a new pull request, #541:
URL: https://github.com/apache/iceberg-cpp/pull/541
When using system Arrow, ensure Parquet is also discovered so Parquet::parquet_* targets are available for iceberg_bundle linking. This restores find_package(Parquet) and adds Parquet to ICEBERG_SYSTEM_DEPENDENCIES to avoid missing target errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] CMake: require Parquet when using system Arrow [iceberg-cpp]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on code in PR #541:
URL: https://github.com/apache/iceberg-cpp/pull/541#discussion_r2736533987
##########
cmake_modules/IcebergThirdpartyToolchain.cmake:
##########
@@ -151,7 +151,9 @@ function(resolve_arrow_dependency)
endif()
else()
set(ARROW_VENDORED FALSE)
- list(APPEND ICEBERG_SYSTEM_DEPENDENCIES Arrow)
+ find_package(Arrow CONFIG REQUIRED)
Review Comment:
I think this is redundant, but it doesn't hurt to add this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] CMake: require Parquet when using system Arrow [iceberg-cpp]
Posted by "MisterRaindrop (via GitHub)" <gi...@apache.org>.
MisterRaindrop commented on PR #541:
URL: https://github.com/apache/iceberg-cpp/pull/541#issuecomment-3810896672
Do you mean doing it this way during the CMake compilation?
if set xxx_SOURCE_DIR like?
```
cmake -S . -B build -G Ninja -DARROW_SOURCE_DIR=/opt/thirdpath/arrow -DPARQUET_SOURCE_DIR=/opt/thirdpath/parquet
```
if not set xxx_SOURCE_DIR find path in system like `/usr/local/` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] CMake: require Parquet when using system Arrow [iceberg-cpp]
Posted by "MisterRaindrop (via GitHub)" <gi...@apache.org>.
MisterRaindrop commented on PR #541:
URL: https://github.com/apache/iceberg-cpp/pull/541#issuecomment-3810628533
could you please tell me which libraries were used, it would be easier for me to investigate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] CMake: require Parquet when using system Arrow [iceberg-cpp]
Posted by "zhjwpku (via GitHub)" <gi...@apache.org>.
zhjwpku commented on PR #541:
URL: https://github.com/apache/iceberg-cpp/pull/541#issuecomment-3810669321
> could you please tell me which libraries were used, it would be easier for me to investigate.
Like avro-cpp, nanoarrow, etc., I think each of these third-party libraries has a `xxx_SOURCE_DIR` condition check, if not set, then it's a system dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix(cmake): require Parquet when using system Arrow [iceberg-cpp]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac merged PR #541:
URL: https://github.com/apache/iceberg-cpp/pull/541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org