You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tvm.apache.org by mvermeulen <no...@github.com> on 2020/08/26 20:53:45 UTC

[apache/incubator-tvm] ROCm changed name of library and removed the old one in ROCm 3.7 release. (#6345)

Thanks for contributing to TVM!   Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.

You can view, comment on, or merge this pull request online at:

  https://github.com/apache/incubator-tvm/pull/6345

-- Commit Summary --

  * ROCm changed name of library and removed old one in ROCm 3.7 release.

-- File Changes --

    M cmake/util/FindROCM.cmake (2)

-- Patch Links --

https://github.com/apache/incubator-tvm/pull/6345.patch
https://github.com/apache/incubator-tvm/pull/6345.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-tvm/pull/6345

Re: [apache/incubator-tvm] ROCm changed name of library and removed the old one in ROCm 3.7 release. (#6345)

Posted by mvermeulen <no...@github.com>.

The new library name was introduced in ROCm 3.5.  The old library name was deleted in ROCm 3.7.

So this change makes ROCm 3.5 or later a requirement for mainline TVM, and fixes a break with ROCm 3.7 when the old name was deleted.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-tvm/pull/6345#issuecomment-681141322

Re: [apache/incubator-tvm] ROCm changed name of library and removed the old one in ROCm 3.7 release. (#6345)

Posted by masahi <no...@github.com>.

Merged #6345 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-tvm/pull/6345#event-3697255873

Re: [apache/incubator-tvm] ROCm changed name of library and removed the old one in ROCm 3.7 release. (#6345)

Posted by masahi <no...@github.com>.

Does this change make rocm 3.7 requirement for TVM? This is only for confirmation, I'm +1 for tracking the latest release.

cc @t-vi 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-tvm/pull/6345#issuecomment-681123947

Re: [apache/incubator-tvm] ROCm changed name of library and removed the old one in ROCm 3.7 release. (#6345)

Posted by Thomas Viehmann <no...@github.com>.

Seems good to me. If we are giving up on pre-3.3 compat, I should also remove the code object v3 workaround I introduced in the spring in favour of 3.5+. (I'll send a PR.)


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-tvm/pull/6345#issuecomment-681203248