You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Dezhi Cai (Jira)" <ji...@apache.org> on 2019/11/27 05:43:00 UTC
[jira] [Comment Edited] (FLINK-14962) FindBugs warnings:
Inefficient use of keySet iterator instead of entrySet iterator
[ https://issues.apache.org/jira/browse/FLINK-14962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16983179#comment-16983179 ]
Dezhi Cai edited comment on FLINK-14962 at 11/27/19 5:42 AM:
-------------------------------------------------------------
I create a PR as my first contribution to flink. Look forward to working with great guys in the community..
was (Author: caidezhi655):
I create a PR as my first contribution to flink. Looking forward to working with great guys in the community..
> FindBugs warnings: Inefficient use of keySet iterator instead of entrySet iterator
> ----------------------------------------------------------------------------------
>
> Key: FLINK-14962
> URL: https://issues.apache.org/jira/browse/FLINK-14962
> Project: Flink
> Issue Type: Bug
> Components: Connectors / Common, Formats (JSON, Avro, Parquet, ORC, SequenceFile)
> Affects Versions: 1.8.0, 1.9.0, 1.9.1
> Reporter: Dezhi Cai
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> FindBugs report WMI_WRONG_MAP_ITERATOR warnings on master.
> related class :
> org.apache.flink.formats.parquet.ParquetMapInputFormat
> org.apache.flink.graph.library.CommunityDetection
> org.apache.flink.streaming.connectors.fs.bucketing.BucketingSink (already marked as "Deprecated")
>
> The description of the bug is as follows:
> *WMI: Inefficient use of keySet iterator instead of entrySet iterator (WMI_WRONG_MAP_ITERATOR)*
> This method accesses the value of a Map entry, using a key that was retrieved from a keySet iterator. It is more efficient to use an iterator on the entrySet of the map, to avoid the Map.get(key) lookup.
> [http://findbugs.sourceforge.net/bugDescriptions.html#WMI_WRONG_MAP_ITERATOR]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)