You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/07/06 13:22:21 UTC
[GitHub] [nifi-minifi-cpp] arpadboda opened a new pull request #831: MINIFICPP-1280 - StringUtils::replaceAll hangs in case from_string is…
arpadboda opened a new pull request #831:
URL: https://github.com/apache/nifi-minifi-cpp/pull/831
… empty
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #831: MINIFICPP-1280 - StringUtils::replaceAll hangs in case from_string is…
Posted by GitBox <gi...@apache.org>.
fgerlits commented on a change in pull request #831:
URL: https://github.com/apache/nifi-minifi-cpp/pull/831#discussion_r450239801
##########
File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp
##########
@@ -572,6 +572,9 @@ bool ConsumeWindowsEventLog::createEventRender(EVT_HANDLE hEvent, EventRender& e
for (const auto &mapEntry : walker.getIdentifiers()) {
// replace the identifiers with their translated strings.
+ if (mapEntry.first.empty() || mapEntry.second.empty()) {
+ continue; // This is most probably a result of a failed ID resolution
+ }
Review comment:
I would move this check to the top of `StringUtils::replaceAll()`, as a `"" -> ""` replacement should always be a no-op, and there is no reason to potentially iterate over a long string character-by-character in these cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #831: MINIFICPP-1280 - StringUtils::replaceAll hangs in case from_string is…
Posted by GitBox <gi...@apache.org>.
arpadboda closed pull request #831:
URL: https://github.com/apache/nifi-minifi-cpp/pull/831
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #831: MINIFICPP-1280 - StringUtils::replaceAll hangs in case from_string is…
Posted by GitBox <gi...@apache.org>.
fgerlits commented on a change in pull request #831:
URL: https://github.com/apache/nifi-minifi-cpp/pull/831#discussion_r450239801
##########
File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp
##########
@@ -572,6 +572,9 @@ bool ConsumeWindowsEventLog::createEventRender(EVT_HANDLE hEvent, EventRender& e
for (const auto &mapEntry : walker.getIdentifiers()) {
// replace the identifiers with their translated strings.
+ if (mapEntry.first.empty() || mapEntry.second.empty()) {
+ continue; // This is most probably a result of a failed ID resolution
+ }
Review comment:
I would move this check to the top of `StringUtils::replaceAll()`, as a `"" -> ""` replacement should always be a no-op, and there is no reason to iterate over a long string character-by-character in these cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org