You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2022/10/14 07:32:26 UTC

[GitHub] [jackrabbit-oak] anchela opened a new pull request, #732: OAK-9966 : Internal code calls Node.isCheckedOut and VersionManager.isCheckedOut

anchela opened a new pull request, #732:
URL: https://github.com/apache/jackrabbit-oak/pull/732

   hi @joerghoh , @mreutegg , @reschke , @Joscorbe , i would highly appreciate if you could take a careful look at this PR for the version-mgt implementation.
   
   - as outlined in the ticket the implementation calling JCR API (and by doing so resolving the node again) is suboptiomal..... so the goal was to get rid of all JCR calls that create another operation-object inside a JCR call and avoid resolving the node again.
   - the check for the tree.existing in ReadOnlyVersionManager is IMHO redundant (and not relevant. i added an additional line in the comment illustrating how it could be fixed if really needed and added a test illustrating the mismatch that we had/have. i verified that the test both passed before and after my change)
   
   please pay attention to the following subtle changes and let me know if you see any issue with that:
   - ItemImpl.getVersionManager no longer calls JCR API on Workspace but the internal variant that returns the impl and does not perform a check if the session is still alive. that is handled in preconditions of the individual JCR calls)
   - all internal checks for the node being checkedout should now call the internal method taking a nodedelegate without creating a separate operation object


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jackrabbit-oak] anchela commented on pull request #732: OAK-9966 : Internal code calls Node.isCheckedOut and VersionManager.isCheckedOut

Posted by GitBox <gi...@apache.org>.
anchela commented on PR #732:
URL: https://github.com/apache/jackrabbit-oak/pull/732#issuecomment-1278955540

   > The test failure is most likely unrelated.
   
   thanks, @mreutegg 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jackrabbit-oak] mreutegg commented on pull request #732: OAK-9966 : Internal code calls Node.isCheckedOut and VersionManager.isCheckedOut

Posted by GitBox <gi...@apache.org>.
mreutegg commented on PR #732:
URL: https://github.com/apache/jackrabbit-oak/pull/732#issuecomment-1278881175

   > i haven't seen `org.apache.jackrabbit.oak.plugins.document.VersionGCWithSplitTest` failing when i ran the build locally. does that sound like being related to my patch?
   
   The test failure is most likely unrelated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jackrabbit-oak] anchela merged pull request #732: OAK-9966 : Internal code calls Node.isCheckedOut and VersionManager.isCheckedOut

Posted by GitBox <gi...@apache.org>.
anchela merged PR #732:
URL: https://github.com/apache/jackrabbit-oak/pull/732


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jackrabbit-oak] anchela commented on pull request #732: OAK-9966 : Internal code calls Node.isCheckedOut and VersionManager.isCheckedOut

Posted by GitBox <gi...@apache.org>.
anchela commented on PR #732:
URL: https://github.com/apache/jackrabbit-oak/pull/732#issuecomment-1281887315

   @reschke ..... uuuuhhhhh thanks..... not sure it is justified :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jackrabbit-oak] anchela commented on pull request #732: OAK-9966 : Internal code calls Node.isCheckedOut and VersionManager.isCheckedOut

Posted by GitBox <gi...@apache.org>.
anchela commented on PR #732:
URL: https://github.com/apache/jackrabbit-oak/pull/732#issuecomment-1278781668

   @mreutegg, i haven't seen `org.apache.jackrabbit.oak.plugins.document.VersionGCWithSplitTest` failing when i ran the build locally. does that sound like being related to my patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org