[GitHub] [hudi] kkrugler commented on pull request #7955: [HUDI-5649] Unify all the loggers to slf4j

["kkrugler (via GitHub)" <gi...@apache.org>]

kkrugler commented on PR #7955:
URL: https://github.com/apache/hudi/pull/7955#issuecomment-1468069523

   Whenever a project can be used as a library by another project, it's really important to pick a logging facade that facilitates easy integration with the other project's logging infrastructure. Flink (any many other open source projects) uses slf4j as the facade, and (by default) Log4 2 as the logging implementation.
   
   The main issues we've run into with Hudi & logging are:
   
   - Direct use of Log4J. This means we have to (a) explicitly exclude the log4j dependency from our dependency on `hudi-flink`, and (b) add the `log4j-over-slf4j` dependency, so that logging flows to the Flink logging infrastructure properly. Otherwise changes made to log4j2 properties aren't reflected in logging output, for example.
   - Use of `com.esotericsoftware.minlog.Log`, which is setting output to System.out, which is being captured by Flink in a completely different output file, and with a different output format.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org