You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by dp...@apache.org on 2022/04/20 11:11:47 UTC

[superset] branch master updated: fix: small cleanup for created by me dashboards API (#19755)

This is an automated email from the ASF dual-hosted git repository.

dpgaspar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new f06db796b5 fix: small cleanup for created by me dashboards API (#19755)
f06db796b5 is described below

commit f06db796b5a609915d96b0a176f474d5142d9813
Author: Daniel Vaz Gaspar <da...@gmail.com>
AuthorDate: Wed Apr 20 12:11:38 2022 +0100

    fix: small cleanup for created by me dashboards API (#19755)
---
 superset/constants.py      | 1 -
 superset/dashboards/api.py | 1 -
 superset/views/core.py     | 2 +-
 3 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/superset/constants.py b/superset/constants.py
index 2269bdc7b1..8399aa457a 100644
--- a/superset/constants.py
+++ b/superset/constants.py
@@ -100,7 +100,6 @@ MODEL_VIEW_RW_METHOD_PERMISSION_MAP = {
 
 MODEL_API_RW_METHOD_PERMISSION_MAP = {
     "bulk_delete": "write",
-    "created_by_me": "read",
     "delete": "write",
     "distinct": "read",
     "get": "read",
diff --git a/superset/dashboards/api.py b/superset/dashboards/api.py
index 277e0d10c3..5e3f78a953 100644
--- a/superset/dashboards/api.py
+++ b/superset/dashboards/api.py
@@ -140,7 +140,6 @@ class DashboardRestApi(BaseSupersetModelRestApi):
         "set_embedded",
         "delete_embedded",
         "thumbnail",
-        "created_by_me",
     }
     resource_name = "dashboard"
     allow_browser_login = True
diff --git a/superset/views/core.py b/superset/views/core.py
index 1aa348d713..68ac74b365 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -1587,7 +1587,7 @@ class Superset(BaseSupersetView):  # pylint: disable=too-many-public-methods
     @event_logger.log_this
     @expose("/created_dashboards/<int:user_id>/", methods=["GET"])
     def created_dashboards(self, user_id: int) -> FlaskResponse:
-        logging.warning(
+        logger.warning(
             "%s.created_dashboards "
             "This API endpoint is deprecated and will be removed in version 3.0.0",
             self.__class__.__name__,