You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/11/07 20:05:38 UTC

[GitHub] [arrow] westonpace commented on a change in pull request #11632: ARROW-14620: [Python] Missing bindings for existing_data_behavior makes it impossible to maintain old behavior

westonpace commented on a change in pull request #11632:
URL: https://github.com/apache/arrow/pull/11632#discussion_r744309138



##########
File path: python/pyarrow/dataset.py
##########
@@ -798,6 +799,18 @@ def write_dataset(data, base_dir, basename_template=None, format=None,
 
             def file_visitor(written_file):
                 visited_paths.append(written_file.path)
+    existing_data_behavior : 'error' | 'overwrite' | 'delete_matching'

Review comment:
       I'm fine with overwrite_or_ignore.  I changed it.  I also clarified the docstring for the option a little to be explicit that non-matching files are left alone.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org