You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/04/14 12:19:51 UTC
[GitHub] [incubator-superset] codecov-io commented on issue #7297: [WIP]
bugfix: Tables and schemas with slashes break SQL Lab
codecov-io commented on issue #7297: [WIP] bugfix: Tables and schemas with slashes break SQL Lab
URL: https://github.com/apache/incubator-superset/pull/7297#issuecomment-482962424
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7297?src=pr&el=h1) Report
> Merging [#7297](https://codecov.io/gh/apache/incubator-superset/pull/7297?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b1ebfbc5776aa2347254beb9c1bd534f4ca5a47b?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `76.92%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/7297?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7297 +/- ##
==========================================
+ Coverage 64.92% 64.93% +<.01%
==========================================
Files 424 424
Lines 20594 20598 +4
Branches 2282 2282
==========================================
+ Hits 13371 13375 +4
Misses 7100 7100
Partials 123 123
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/7297?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/assets/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/7297/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvYWN0aW9ucy9zcWxMYWIuanM=) | `70.35% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7297/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL1RhYmxlU2VsZWN0b3IuanN4) | `84.67% <100%> (ø)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/7297/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.26% <100%> (+0.04%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/7297/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75% <71.42%> (+0.03%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7297?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7297?src=pr&el=footer). Last update [b1ebfbc...c806126](https://codecov.io/gh/apache/incubator-superset/pull/7297?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org