You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/11/30 11:42:20 UTC

[GitHub] [dubbo] BurningCN opened a new pull request #9333: Optimize service key generate

BurningCN opened a new pull request #9333:
URL: https://github.com/apache/dubbo/pull/9333


   ## What is the purpose of the change
   
   Use existing methods to generate serviceKey for SimpleReferenceCache 
   
   1.Use existing methods to generate serviceKey for SimpleReferenceCache
   2.add test case for ServiceInstanceHostPortCustomizer
   3.Remove the toString method of AbstractConfig subclass
   4.Add unit test for ConfigScopeModelInitializer


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter commented on pull request #9333: Use existing methods to generate serviceKey for SimpleReferenceCache

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #9333:
URL: https://github.com/apache/dubbo/pull/9333#issuecomment-982591202


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9333?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9333](https://codecov.io/gh/apache/dubbo/pull/9333?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a1ab186) into [3.0](https://codecov.io/gh/apache/dubbo/commit/5349c13a36d277a090e1dc68fbe7c3b46d78fc90?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5349c13) will **decrease** coverage by `0.04%`.
   > The diff coverage is `75.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9333/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9333      +/-   ##
   ============================================
   - Coverage     65.31%   65.27%   -0.05%     
   + Complexity      342      341       -1     
   ============================================
     Files          1201     1201              
     Lines         51842    51769      -73     
     Branches       7723     7721       -2     
   ============================================
   - Hits          33860    33790      -70     
   + Misses        14368    14362       -6     
   - Partials       3614     3617       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...apache/dubbo/common/extension/ExtensionLoader.java](https://codecov.io/gh/apache/dubbo/pull/9333/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL0V4dGVuc2lvbkxvYWRlci5qYXZh) | `81.42% <ø> (-0.04%)` | :arrow_down: |
   | [...n/java/org/apache/dubbo/config/ProtocolConfig.java](https://codecov.io/gh/apache/dubbo/pull/9333/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvUHJvdG9jb2xDb25maWcuamF2YQ==) | `87.02% <ø> (-2.92%)` | :arrow_down: |
   | [...n/java/org/apache/dubbo/config/ProviderConfig.java](https://codecov.io/gh/apache/dubbo/pull/9333/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvUHJvdmlkZXJDb25maWcuamF2YQ==) | `85.55% <ø> (-3.43%)` | :arrow_down: |
   | [...onfig/invoker/DelegateProviderMetaDataInvoker.java](https://codecov.io/gh/apache/dubbo/pull/9333/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9pbnZva2VyL0RlbGVnYXRlUHJvdmlkZXJNZXRhRGF0YUludm9rZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...pache/dubbo/config/utils/SimpleReferenceCache.java](https://codecov.io/gh/apache/dubbo/pull/9333/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy91dGlscy9TaW1wbGVSZWZlcmVuY2VDYWNoZS5qYXZh) | `66.66% <50.00%> (-2.09%)` | :arrow_down: |
   | [...a/org/apache/dubbo/common/BaseServiceMetadata.java](https://codecov.io/gh/apache/dubbo/pull/9333/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vQmFzZVNlcnZpY2VNZXRhZGF0YS5qYXZh) | `94.73% <100.00%> (ø)` | |
   | [.../org/apache/dubbo/rpc/protocol/tri/WriteQueue.java](https://codecov.io/gh/apache/dubbo/pull/9333/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvV3JpdGVRdWV1ZS5qYXZh) | `87.50% <0.00%> (-6.25%)` | :arrow_down: |
   | [...va/org/apache/dubbo/registry/RegistryNotifier.java](https://codecov.io/gh/apache/dubbo/pull/9333/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9SZWdpc3RyeU5vdGlmaWVyLmphdmE=) | `79.48% <0.00%> (-2.57%)` | :arrow_down: |
   | [...bbo/common/resource/GlobalResourcesRepository.java](https://codecov.io/gh/apache/dubbo/pull/9333/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vcmVzb3VyY2UvR2xvYmFsUmVzb3VyY2VzUmVwb3NpdG9yeS5qYXZh) | `70.90% <0.00%> (-1.82%)` | :arrow_down: |
   | [...exchange/support/header/HeaderExchangeHandler.java](https://codecov.io/gh/apache/dubbo/pull/9333/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFkZXJFeGNoYW5nZUhhbmRsZXIuamF2YQ==) | `66.37% <0.00%> (-1.77%)` | :arrow_down: |
   | ... and [8 more](https://codecov.io/gh/apache/dubbo/pull/9333/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9333?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9333?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5349c13...a1ab186](https://codecov.io/gh/apache/dubbo/pull/9333?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] AlbumenJ merged pull request #9333: Use existing methods to generate serviceKey for SimpleReferenceCache

Posted by GitBox <gi...@apache.org>.
AlbumenJ merged pull request #9333:
URL: https://github.com/apache/dubbo/pull/9333


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9333: Use existing methods to generate serviceKey for SimpleReferenceCache

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9333:
URL: https://github.com/apache/dubbo/pull/9333#issuecomment-982591202


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9333?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9333](https://codecov.io/gh/apache/dubbo/pull/9333?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a1ab186) into [3.0](https://codecov.io/gh/apache/dubbo/commit/5349c13a36d277a090e1dc68fbe7c3b46d78fc90?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5349c13) will **decrease** coverage by `0.02%`.
   > The diff coverage is `75.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9333/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9333      +/-   ##
   ============================================
   - Coverage     65.31%   65.28%   -0.03%     
   + Complexity      342      341       -1     
   ============================================
     Files          1201     1201              
     Lines         51842    51769      -73     
     Branches       7723     7721       -2     
   ============================================
   - Hits          33860    33797      -63     
   + Misses        14368    14358      -10     
     Partials       3614     3614              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...apache/dubbo/common/extension/ExtensionLoader.java](https://codecov.io/gh/apache/dubbo/pull/9333/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL0V4dGVuc2lvbkxvYWRlci5qYXZh) | `81.42% <ø> (-0.04%)` | :arrow_down: |
   | [...n/java/org/apache/dubbo/config/ProtocolConfig.java](https://codecov.io/gh/apache/dubbo/pull/9333/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvUHJvdG9jb2xDb25maWcuamF2YQ==) | `87.02% <ø> (-2.92%)` | :arrow_down: |
   | [...n/java/org/apache/dubbo/config/ProviderConfig.java](https://codecov.io/gh/apache/dubbo/pull/9333/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvUHJvdmlkZXJDb25maWcuamF2YQ==) | `85.55% <ø> (-3.43%)` | :arrow_down: |
   | [...onfig/invoker/DelegateProviderMetaDataInvoker.java](https://codecov.io/gh/apache/dubbo/pull/9333/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9pbnZva2VyL0RlbGVnYXRlUHJvdmlkZXJNZXRhRGF0YUludm9rZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...pache/dubbo/config/utils/SimpleReferenceCache.java](https://codecov.io/gh/apache/dubbo/pull/9333/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy91dGlscy9TaW1wbGVSZWZlcmVuY2VDYWNoZS5qYXZh) | `66.66% <50.00%> (-2.09%)` | :arrow_down: |
   | [...a/org/apache/dubbo/common/BaseServiceMetadata.java](https://codecov.io/gh/apache/dubbo/pull/9333/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vQmFzZVNlcnZpY2VNZXRhZGF0YS5qYXZh) | `94.73% <100.00%> (ø)` | |
   | [.../org/apache/dubbo/rpc/protocol/tri/WriteQueue.java](https://codecov.io/gh/apache/dubbo/pull/9333/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvV3JpdGVRdWV1ZS5qYXZh) | `87.50% <0.00%> (-6.25%)` | :arrow_down: |
   | [...bbo/common/resource/GlobalResourcesRepository.java](https://codecov.io/gh/apache/dubbo/pull/9333/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vcmVzb3VyY2UvR2xvYmFsUmVzb3VyY2VzUmVwb3NpdG9yeS5qYXZh) | `70.90% <0.00%> (-1.82%)` | :arrow_down: |
   | [...exchange/support/header/HeaderExchangeHandler.java](https://codecov.io/gh/apache/dubbo/pull/9333/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFkZXJFeGNoYW5nZUhhbmRsZXIuamF2YQ==) | `66.37% <0.00%> (-1.77%)` | :arrow_down: |
   | [...bo/registry/support/CacheableFailbackRegistry.java](https://codecov.io/gh/apache/dubbo/pull/9333/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L0NhY2hlYWJsZUZhaWxiYWNrUmVnaXN0cnkuamF2YQ==) | `77.10% <0.00%> (-1.21%)` | :arrow_down: |
   | ... and [9 more](https://codecov.io/gh/apache/dubbo/pull/9333/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9333?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9333?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5349c13...a1ab186](https://codecov.io/gh/apache/dubbo/pull/9333?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org