You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/12/09 21:06:50 UTC
[GitHub] [pinot] walterddr opened a new issue, #9959: [multistage][flakytest] ResourceBasedQueriesTest.testQueryTestCasesWithH2 is flaky
walterddr opened a new issue, #9959:
URL: https://github.com/apache/pinot/issues/9959
observed multiple times when random timeout occurs on 3-way or more join queries.
example: https://github.com/apache/pinot/actions/runs/3660353652/jobs/6187392596
```
2022-12-09T20:09:11.9697742Z [ERROR] org.apache.pinot.query.runtime.queries.ResourceBasedQueriesTest.testQueryTestCasesWithH2[where_clause_tests, SELECT * FROM where_clause_tests_tbl WHERE intCol IN (SELECT a.intCol FROM where_clause_tests_tbl AS a JOIN where_clause_tests_tbl AS b ON a.strCol = b.strCol WHERE MOD(a.intCol, 2) = MOD(b.intCol, 2)), null](8) Time elapsed: 10.109 s <<< FAILURE!
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on issue #9959: [multistage][flakytest] ResourceBasedQueriesTest.testQueryTestCasesWithH2 is flaky
Posted by GitBox <gi...@apache.org>.
walterddr commented on issue #9959:
URL: https://github.com/apache/pinot/issues/9959#issuecomment-1344859789
several others i can find:
https://github.com/apache/pinot/actions/runs/3651519056/jobs/6168825587
https://github.com/apache/pinot/actions/runs/3653818305/jobs/6173667324
https://github.com/apache/pinot/actions/runs/3642421827/jobs/6149508171
occurs all after Dec 6, 2022 (76c649258c625d431a42ff1fbc1b3003fe013066)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] agavra commented on issue #9959: [multistage][flakytest] ResourceBasedQueriesTest.testQueryTestCasesWithH2 is flaky
Posted by GitBox <gi...@apache.org>.
agavra commented on issue #9959:
URL: https://github.com/apache/pinot/issues/9959#issuecomment-1346932947
I think this might be related to the threading model - I just realized that for joins the notification system might be problematic, imagine the following:
1. you get a notification that the probe table has data available and EOS
2. the join operator is scheduled, but the broadcast table is incomplete so nothing happens
3. the broadcast table completes
4. !!! the join is never scheduled again because we already "used" the notification for (1)
#9934 will fix this in an unideal way,I'll think of how to fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] agavra commented on issue #9959: [multistage][flakytest] ResourceBasedQueriesTest.testQueryTestCasesWithH2 is flaky
Posted by GitBox <gi...@apache.org>.
agavra commented on issue #9959:
URL: https://github.com/apache/pinot/issues/9959#issuecomment-1347039570
Three potential fixes:
1. have two callbacks: onDataAvailable and onDataConsumed and only “use” a seen mail notification when onDataConsumed is called. the upside is that this gives a lot of flexibility to the scheduler, the downside is that if data is available from the probing side of the join but not the broadcast it will keep being scheduled unless I add some really fancy scheduling logic that knows to only schedule joins when one mailbox is complete
2. I can make the HashJoinOperator cache data it reads from the probing mailbox. The obvious issue there is a potential memory pressure - this would be mitigated with flow control in place.
3. only schedule when _seenMail contains mailboxes from the “first” mailbox in the list of mailboxes instead of any mailbox the operator reads from. we could make this more generic by instead of just using the first we could have the API return any mailboxes that we’re ready to read from. downside is that this requires some pretty tightly coupled abstractions so we need to think through the API design well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on issue #9959: [multistage][flakytest] ResourceBasedQueriesTest.testQueryTestCasesWithH2 is flaky
Posted by GitBox <gi...@apache.org>.
walterddr commented on issue #9959:
URL: https://github.com/apache/pinot/issues/9959#issuecomment-1345763911
Seems like this query fails the most often
```
org.apache.pinot.query.runtime.queries.ResourceBasedQueriesTest.testQueryTestCasesWithH2[where_clause_tests, SELECT * FROM where_clause_tests_tbl WHERE intCol IN (SELECT a.intCol FROM where_clause_tests_tbl AS a JOIN where_clause_tests_tbl AS b ON a.strCol = b.strCol WHERE MOD(a.intCol, 2) = MOD(b.intCol, 2)), null](8) Time elapsed: 10.079 s <<< FAILURE!
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org