[GitHub] [rocketmq] cserwen commented on a diff in pull request #6443: [ISSUE #6442]Optimize RebalanceImpl#rebalanceByTopic method

["cserwen (via GitHub)" <gi...@apache.org>]

cserwen commented on code in PR #6443:
URL: https://github.com/apache/rocketmq/pull/6443#discussion_r1151583387


##########
client/src/main/java/org/apache/rocketmq/client/impl/consumer/RebalanceImpl.java:
##########
@@ -310,17 +308,16 @@ private boolean rebalanceByTopic(final String topic, final boolean isOrder) {
 
                     balanced = mqSet.equals(getWorkingMessageQueue(topic));
                 } else {
-                    this.messageQueueChanged(topic, Collections.<MessageQueue>emptySet(), Collections.<MessageQueue>emptySet());

Review Comment:
   For the Client module, we should consider whether we need to support JDK1.6



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org