You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "humengyu2012 (via GitHub)" <gi...@apache.org> on 2023/11/16 19:37:39 UTC
[PR] PrestoDB use inject [incubator-paimon-presto]
humengyu2012 opened a new pull request, #16:
URL: https://github.com/apache/incubator-paimon-presto/pull/16
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PrestoDB use inject [incubator-paimon-presto]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #16:
URL: https://github.com/apache/incubator-paimon-presto/pull/16#discussion_r1401375792
##########
README.md:
##########
@@ -5,3 +5,77 @@ This repository is Presto Connector for the [Apache Paimon](https://paimon.apach
## About
Apache Paimon is an open source project of [The Apache Software Foundation](https://apache.org/) (ASF).
+
+## Getting Started
+
+### Build
+
+| Version | Command |
+|-----------------|-------------------------------------------------------------|
+| [0.236, 0.268) | `mvn clean install -DskipTests -am -pl paimon-presto-0.236` |
Review Comment:
If we have this, do we need to have paimon-presto-0.236 and 0.238?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PrestoDB use inject [incubator-paimon-presto]
Posted by "feloxx (via GitHub)" <gi...@apache.org>.
feloxx commented on PR #16:
URL: https://github.com/apache/incubator-paimon-presto/pull/16#issuecomment-1815704890
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PrestoDB use inject [incubator-paimon-presto]
Posted by "humengyu2012 (via GitHub)" <gi...@apache.org>.
humengyu2012 commented on PR #16:
URL: https://github.com/apache/incubator-paimon-presto/pull/16#issuecomment-1815197172
I changed the packaging method and modified the `pom.xml` file extensively. I'm not sure if this is a good approach. Could you please take a look? @JingsongLi I've documented the new packaging method in the `README.md`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PrestoDB use inject [incubator-paimon-presto]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #16:
URL: https://github.com/apache/incubator-paimon-presto/pull/16#issuecomment-1817846440
You need to modify test dependencies too to make test passing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PrestoDB use inject [incubator-paimon-presto]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #16:
URL: https://github.com/apache/incubator-paimon-presto/pull/16#discussion_r1401375792
##########
README.md:
##########
@@ -5,3 +5,77 @@ This repository is Presto Connector for the [Apache Paimon](https://paimon.apach
## About
Apache Paimon is an open source project of [The Apache Software Foundation](https://apache.org/) (ASF).
+
+## Getting Started
+
+### Build
+
+| Version | Command |
+|-----------------|-------------------------------------------------------------|
+| [0.236, 0.268) | `mvn clean install -DskipTests -am -pl paimon-presto-0.236` |
Review Comment:
Can here just be:
1. first `mvn clean install -DskipTests`
2. then:
```
| Version | Command |
|-----------------|-------------------------------------------------------------|
| [0.236, 0.268) | `./paimon-presto-0.236/target/paimon-presto-0.236-0.6-SNAPSHOT-plugin.tar.gz` |
| [0.268, 0.273) | `./paimon-presto-0.238/target/paimon-presto-0.238-0.6-SNAPSHOT-plugin.tar.gz` |
| [0.273, latest] | `./paimon-presto-0.273/target/paimon-presto-0.273-0.6-SNAPSHOT-plugin.tar.gz` |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PrestoDB use inject [incubator-paimon-presto]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi closed pull request #16: PrestoDB use inject
URL: https://github.com/apache/incubator-paimon-presto/pull/16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PrestoDB use inject [incubator-paimon-presto]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #16:
URL: https://github.com/apache/incubator-paimon-presto/pull/16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PrestoDB use inject [incubator-paimon-presto]
Posted by "humengyu2012 (via GitHub)" <gi...@apache.org>.
humengyu2012 commented on PR #16:
URL: https://github.com/apache/incubator-paimon-presto/pull/16#issuecomment-1817851385
> You need to modify test dependencies too to make test passing.
Sorry, I will fix the tests later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PrestoDB use inject [incubator-paimon-presto]
Posted by "humengyu2012 (via GitHub)" <gi...@apache.org>.
humengyu2012 commented on PR #16:
URL: https://github.com/apache/incubator-paimon-presto/pull/16#issuecomment-1818258231
rebase main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org