You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Richard Zang <rz...@hortonworks.com> on 2017/04/21 23:55:24 UTC

Review Request 58637: AMBARI-20826 - HIVE "Quick Links" section showing Graphana related quicklinks when Graphana is not installed

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58637/
-----------------------------------------------------------

Review request for Ambari, Jaimin Jetly and Yusaku Sako.


Bugs: AMBARI-20826
    https://issues.apache.org/jira/browse/AMBARI-20826


Repository: ambari


Description
-------

We cannot assume host for master component of current visiting service to be the default host for all quicklinks.
Add component setting for SPARK2 quicklinks.json.


Diffs
-----

  ambari-server/src/main/resources/common-services/SPARK2/2.0.0/quicklinks/quicklinks.json ff285fc 
  ambari-web/app/views/common/quick_view_link_view.js dfaf953 


Diff: https://reviews.apache.org/r/58637/diff/1/


Testing
-------

Manually tested on liver cluster. All unit tests passed.
  20700 passing (24s)
  128 pending


Thanks,

Richard Zang


Re: Review Request 58637: AMBARI-20826 - HIVE "Quick Links" section showing Graphana related quicklinks when Graphana is not installed

Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58637/#review172725
-----------------------------------------------------------


Ship it!




Ship It!

- Jaimin Jetly


On April 21, 2017, 11:55 p.m., Richard Zang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58637/
> -----------------------------------------------------------
> 
> (Updated April 21, 2017, 11:55 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20826
>     https://issues.apache.org/jira/browse/AMBARI-20826
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> We cannot assume host for master component of current visiting service to be the default host for all quicklinks.
> Add component setting for SPARK2 quicklinks.json.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/quicklinks/quicklinks.json ff285fc 
>   ambari-web/app/views/common/quick_view_link_view.js dfaf953 
> 
> 
> Diff: https://reviews.apache.org/r/58637/diff/1/
> 
> 
> Testing
> -------
> 
> Manually tested on liver cluster. All unit tests passed.
>   20700 passing (24s)
>   128 pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>