You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/06/11 01:47:36 UTC

[GitHub] [kylin] zhangayqian opened a new pull request #1253: KYLIN-4394 Fix NoSuchMethod in spark build job after update guava

zhangayqian opened a new pull request #1253:
URL: https://github.com/apache/kylin/pull/1253


   ## Proposed changes
   
   Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
   
   ## Types of changes
   
   What types of changes does your code introduce to Kylin?
   _Put an `x` in the boxes that apply_
   
   - [x] Bugfix (non-breaking change which fixes an issue)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
   - [ ] Documentation Update (if none of the other choices apply)
   
   ## Checklist
   
   _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
   
   - [x] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail
   - [x] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
   - [ ] Compiling and unit tests pass locally with my changes
   - [ ] I have added tests that prove my fix is effective or that my feature works
   - [ ] If this change need a document change, I will prepare another pr against the `document` branch
   - [ ] Any dependent changes have been merged
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kylin] hit-lacus commented on pull request #1253: KYLIN-4394 Fix NoSuchMethod in spark build job after update guava

Posted by GitBox <gi...@apache.org>.
hit-lacus commented on pull request #1253:
URL: https://github.com/apache/kylin/pull/1253#issuecomment-642528809


   LGTM 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kylin] hit-lacus merged pull request #1253: KYLIN-4394 Fix NoSuchMethod in spark build job after update guava

Posted by GitBox <gi...@apache.org>.
hit-lacus merged pull request #1253:
URL: https://github.com/apache/kylin/pull/1253


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kylin] codecov-commenter commented on pull request #1253: KYLIN-4394 Fix NoSuchMethod in spark build job after update guava

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1253:
URL: https://github.com/apache/kylin/pull/1253#issuecomment-642363767


   # [Codecov](https://codecov.io/gh/apache/kylin/pull/1253?src=pr&el=h1) Report
   > Merging [#1253](https://codecov.io/gh/apache/kylin/pull/1253?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/c1705947dc2c04d084a4bf3f4ad15877e1c50b2c&el=desc) will **increase** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/1253/graphs/tree.svg?width=650&height=150&src=pr&token=JawVgbgsVo)](https://codecov.io/gh/apache/kylin/pull/1253?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #1253   +/-   ##
   =========================================
     Coverage     25.71%   25.72%           
     Complexity     6626     6626           
   =========================================
     Files          1484     1484           
     Lines         91189    91188    -1     
     Branches      12726    12726           
   =========================================
   + Hits          23447    23454    +7     
   + Misses        65439    65433    -6     
   + Partials       2303     2301    -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1253?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...pache/kylin/engine/spark/KylinKryoRegistrator.java](https://codecov.io/gh/apache/kylin/pull/1253/diff?src=pr&el=tree#diff-ZW5naW5lLXNwYXJrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3BhcmsvS3lsaW5LcnlvUmVnaXN0cmF0b3IuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/1253/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh) | `81.74% <0.00%> (-0.80%)` | `17.00% <0.00%> (-1.00%)` | |
   | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1253/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0.00%> (+0.60%)` | `7.00% <0.00%> (ø%)` | |
   | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1253/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `66.15% <0.00%> (+2.30%)` | `0.00% <0.00%> (ø%)` | |
   | [...che/kylin/stream/core/storage/CheckPointStore.java](https://codecov.io/gh/apache/kylin/pull/1253/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvQ2hlY2tQb2ludFN0b3JlLmphdmE=) | `66.66% <0.00%> (+3.03%)` | `22.00% <0.00%> (+1.00%)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1253?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1253?src=pr&el=footer). Last update [c170594...68ef5e6](https://codecov.io/gh/apache/kylin/pull/1253?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kylin] coveralls commented on pull request #1253: KYLIN-4394 Fix NoSuchMethod in spark build job after update guava

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #1253:
URL: https://github.com/apache/kylin/pull/1253#issuecomment-642366144


   ## Pull Request Test Coverage Report for [Build 6001](https://coveralls.io/builds/31380040)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage increased (+**0.006%**) to **28.247%**
   
   ---
   
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/31380040/badge)](https://coveralls.io/builds/31380040) |
   | :-- | --: |
   | Change from base [Build 6000](https://coveralls.io/builds/31367055): |  0.006% |
   | Covered Lines: | 25758 |
   | Relevant Lines: | 91188 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kylin] hit-lacus commented on pull request #1253: KYLIN-4394 Fix NoSuchMethod in spark build job after update guava

Posted by GitBox <gi...@apache.org>.
hit-lacus commented on pull request #1253:
URL: https://github.com/apache/kylin/pull/1253#issuecomment-642359236


   ### Reproduce in EMR
   ```
   20/06/10 10:21:20 INFO MemoryStore: Block broadcast_2 stored as values in memory (estimated size 216.5 KB, free 1028.3 MB)
   20/06/10 10:21:20 ERROR KylinKryoRegistrator: failed to load class
   java.lang.ClassNotFoundException: org.apache.kylin.shaded.com.google.common.collect.EmptyImmutableList
   	at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
   	at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
   	at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
   	at java.lang.Class.forName0(Native Method)
   	at java.lang.Class.forName(Class.java:264)
   	at org.apache.kylin.engine.spark.KylinKryoRegistrator.addClassQuitely(KylinKryoRegistrator.java:322)
   	at org.apache.kylin.engine.spark.KylinKryoRegistrator.registerClasses(KylinKryoRegistrator.java:110)
   	at org.apache.spark.serializer.KryoSerializer$$anonfun$newKryo$6.apply(KryoSerializer.scala:137)
   	at org.apache.spark.serializer.KryoSerializer$$anonfun$newKryo$6.apply(KryoSerializer.scala:137)
   	at scala.collection.IndexedSeqOptimized$class.foreach(IndexedSeqOptimized.scala:33)
   	at scala.collection.mutable.ArrayOps$ofRef.foreach(ArrayOps.scala:186)
   	at org.apache.spark.serializer.KryoSerializer.newKryo(KryoSerializer.scala:137)
   	at org.apache.spark.serializer.KryoSerializerInstance.borrowKryo(KryoSerializer.scala:329)
   	at org.apache.spark.serializer.KryoSerializerInstance.<init>(KryoSerializer.scala:314)
   	at org.apache.spark.serializer.KryoSerializer.newInstance(KryoSerializer.scala:223)
   	at org.apache.spark.broadcast.TorrentBroadcast$.blockifyObject(TorrentBroadcast.scala:288)
   	at org.apache.spark.broadcast.TorrentBroadcast.writeBlocks(TorrentBroadcast.scala:127)
   	at org.apache.spark.broadcast.TorrentBroadcast.<init>(TorrentBroadcast.scala:88)
   	at org.apache.spark.broadcast.TorrentBroadcastFactory.newBroadcast(TorrentBroadcastFactory.scala:34)
   	at org.apache.spark.broadcast.BroadcastManager.newBroadcast(BroadcastManager.scala:62)
   	at org.apache.spark.SparkContext.broadcast(SparkContext.scala:1489)
   	at org.apache.spark.scheduler.DAGScheduler.submitMissingTasks(DAGScheduler.scala:1203)
   	at org.apache.spark.scheduler.DAGScheduler.org$apache$spark$scheduler$DAGScheduler$$submitStage(DAGScheduler.scala:1111)
   	at org.apache.spark.scheduler.DAGScheduler$$anonfun$submitWaitingChildStages$6.apply(DAGScheduler.scala:924)
   	at org.apache.spark.scheduler.DAGScheduler$$anonfun$submitWaitingChildStages$6.apply(DAGScheduler.scala:923)
   	at scala.collection.IndexedSeqOptimized$class.foreach(IndexedSeqOptimized.scala:33)
   	at scala.collection.mutable.ArrayOps$ofRef.foreach(ArrayOps.scala:186)
   	at org.apache.spark.scheduler.DAGScheduler.submitWaitingChildStages(DAGScheduler.scala:923)
   	at org.apache.spark.scheduler.DAGScheduler.handleTaskCompletion(DAGScheduler.scala:1472)
   	at org.apache.spark.scheduler.DAGSchedulerEventProcessLoop.doOnReceive(DAGScheduler.scala:2261)
   	at org.apache.spark.scheduler.DAGSchedulerEventProcessLoop.onReceive(DAGScheduler.scala:2213)
   	at org.apache.spark.scheduler.DAGSchedulerEventProcessLoop.onReceive(DAGScheduler.scala:2202)
   	at org.apache.spark.util.EventLoop$$anon$1.run(EventLoop.scala:49)
   20/06/10 10:21:20 INFO MemoryStore: Block broadcast_2_piece0 stored as bytes in memory (estimated size 45.1 KB, free 1028.3 MB)
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org