You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/10/12 01:35:27 UTC

[GitHub] [dubbo-go-hessian2] ChangedenCZD commented on a change in pull request #283: fixed: #282

ChangedenCZD commented on a change in pull request #283:
URL: https://github.com/apache/dubbo-go-hessian2/pull/283#discussion_r726695181



##########
File path: encode.go
##########
@@ -155,6 +162,14 @@ func (e *Encoder) Encode(v interface{}) error {
 
 	default:
 		t := UnpackPtrType(reflect.TypeOf(v))
+
+		if DecodeTypeRegexp.Match([]byte(t.String())) { // unpack base type

Review comment:
       如果移动到下面的default，会进行了其它无用的判断




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org