You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by 1ambda <gi...@git.apache.org> on 2016/08/10 11:00:58 UTC

[GitHub] kafka pull request #1717: KAFKA-3742: Can't run bin/connect-*.sh with -daemo...

GitHub user 1ambda opened a pull request:

    https://github.com/apache/kafka/pull/1717

    KAFKA-3742: Can't run bin/connect-*.sh with -daemon flag

    ## Problem
    
    Current connect scripts (`connect-distributed.sh`, `connect-standalone.sh`) do not support `-daemon` flag even if users specify the flag
    since `kafka-run-class.sh` requires that the`-daemon` flag should precede other arguments (e.g. class name)
    
    ## Solution
    
    Do the same thing like `kafka-server-start.sh`
    
    - Parse a command
    - Add `-daemon` to `$EXTRA_ARGS` if exists


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/kafka KAFKA-3742-connect-running-as-daemon

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1717.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1717
    
----
commit cecc8578fdb178630f5918fd4de47c556e13b286
Author: 1ambda <1a...@gmail.com>
Date:   2016-08-10T10:52:15Z

    Support ''-daemon' in connect-*.sh

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #1717: KAFKA-3742: (FIX) Can't run bin/connect-*.sh with ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/1717


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---