You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2020/03/17 10:09:06 UTC
[kudu-CR] tablet: cache delta stats when flushing a DMS
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15460
Change subject: tablet: cache delta stats when flushing a DMS
......................................................................
tablet: cache delta stats when flushing a DMS
This allows us to GC ancient rowsets that have had their DMS flushed,
which is likely to be the case, given the default ancient history
period is 7 days.
Change-Id: I26e74467ed180cebbd8da360763ba9498661e5f3
---
M src/kudu/tablet/delta_store.h
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/deltafile-test.cc
M src/kudu/tablet/deltafile.cc
M src/kudu/tablet/deltafile.h
M src/kudu/tablet/deltamemstore.h
M src/kudu/tablet/mt-tablet-test.cc
M src/kudu/tablet/tablet.h
M src/kudu/tablet/tablet_history_gc-test.cc
M src/kudu/tablet/tablet_replica-test.cc
10 files changed, 81 insertions(+), 45 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/15460/1
--
To view, visit http://gerrit.cloudera.org:8080/15460
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I26e74467ed180cebbd8da360763ba9498661e5f3
Gerrit-Change-Number: 15460
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] tablet: cache delta stats when flushing a DMS
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15460
to look at the new patch set (#2).
Change subject: tablet: cache delta stats when flushing a DMS
......................................................................
tablet: cache delta stats when flushing a DMS
This allows us to GC ancient rowsets that have had their DMS flushed,
which is likely to be the case, given the default ancient history
period is 7 days.
Change-Id: I26e74467ed180cebbd8da360763ba9498661e5f3
---
M src/kudu/tablet/delta_store.h
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/deltafile-test.cc
M src/kudu/tablet/deltafile.cc
M src/kudu/tablet/deltafile.h
M src/kudu/tablet/deltamemstore.h
M src/kudu/tablet/mt-tablet-test.cc
M src/kudu/tablet/tablet_history_gc-test.cc
M src/kudu/tablet/tablet_replica-test.cc
9 files changed, 76 insertions(+), 39 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/15460/2
--
To view, visit http://gerrit.cloudera.org:8080/15460
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I26e74467ed180cebbd8da360763ba9498661e5f3
Gerrit-Change-Number: 15460
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] tablet: cache delta stats when flushing a DMS
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15460 )
Change subject: tablet: cache delta stats when flushing a DMS
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15460
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26e74467ed180cebbd8da360763ba9498661e5f3
Gerrit-Change-Number: 15460
Gerrit-PatchSet: 6
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Sat, 21 Mar 2020 04:31:13 +0000
Gerrit-HasComments: No
[kudu-CR] tablet: cache delta stats when flushing a DMS
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15460 )
Change subject: tablet: cache delta stats when flushing a DMS
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15460
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26e74467ed180cebbd8da360763ba9498661e5f3
Gerrit-Change-Number: 15460
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 17 Mar 2020 17:15:18 +0000
Gerrit-HasComments: No
[kudu-CR] tablet: cache delta stats when flushing a DMS
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15460 )
Change subject: tablet: cache delta stats when flushing a DMS
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15460/2/src/kudu/tablet/tablet_replica-test.cc
File src/kudu/tablet/tablet_replica-test.cc:
http://gerrit.cloudera.org:8080/#/c/15460/2/src/kudu/tablet/tablet_replica-test.cc@810
PS2, Line 810: auto live_row_count = METRIC_live_row_count.InstantiateFunctionGauge(
> error: no viable conversion from 'Callback<uint64_t ()>' (aka 'Callback<uns
Done
http://gerrit.cloudera.org:8080/#/c/15460/2/src/kudu/tablet/tablet_replica-test.cc@839
PS2, Line 839: live_row_count = METRIC_live_row_count.InstantiateFunctionGauge(
> error: no viable conversion from 'Callback<uint64_t ()>' (aka 'Callback<uns
Done
--
To view, visit http://gerrit.cloudera.org:8080/15460
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26e74467ed180cebbd8da360763ba9498661e5f3
Gerrit-Change-Number: 15460
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 20 Mar 2020 00:12:22 +0000
Gerrit-HasComments: Yes
[kudu-CR] tablet: cache delta stats when flushing a DMS
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15460
to look at the new patch set (#3).
Change subject: tablet: cache delta stats when flushing a DMS
......................................................................
tablet: cache delta stats when flushing a DMS
This allows us to GC ancient rowsets that have had their DMS flushed,
which is likely to be the case, given the default ancient history
period is 7 days.
Change-Id: I26e74467ed180cebbd8da360763ba9498661e5f3
---
M src/kudu/tablet/delta_store.h
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/deltafile-test.cc
M src/kudu/tablet/deltafile.cc
M src/kudu/tablet/deltafile.h
M src/kudu/tablet/deltamemstore.h
M src/kudu/tablet/mt-tablet-test.cc
M src/kudu/tablet/tablet_history_gc-test.cc
M src/kudu/tablet/tablet_replica-test.cc
9 files changed, 76 insertions(+), 39 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/15460/3
--
To view, visit http://gerrit.cloudera.org:8080/15460
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I26e74467ed180cebbd8da360763ba9498661e5f3
Gerrit-Change-Number: 15460
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] tablet: cache delta stats when flushing a DMS
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15460 )
Change subject: tablet: cache delta stats when flushing a DMS
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15460
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26e74467ed180cebbd8da360763ba9498661e5f3
Gerrit-Change-Number: 15460
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 20 Mar 2020 04:29:21 +0000
Gerrit-HasComments: No
[kudu-CR] tablet: cache delta stats when flushing a DMS
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15460 )
Change subject: tablet: cache delta stats when flushing a DMS
......................................................................
tablet: cache delta stats when flushing a DMS
This allows us to GC ancient rowsets that have had their DMS flushed,
which is likely to be the case, given the default ancient history
period is 7 days.
Change-Id: I26e74467ed180cebbd8da360763ba9498661e5f3
Reviewed-on: http://gerrit.cloudera.org:8080/15460
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/tablet/delta_store.h
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/deltafile-test.cc
M src/kudu/tablet/deltafile.cc
M src/kudu/tablet/deltafile.h
M src/kudu/tablet/deltamemstore.h
M src/kudu/tablet/mt-tablet-test.cc
M src/kudu/tablet/tablet_history_gc-test.cc
M src/kudu/tablet/tablet_replica-test.cc
9 files changed, 76 insertions(+), 39 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15460
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I26e74467ed180cebbd8da360763ba9498661e5f3
Gerrit-Change-Number: 15460
Gerrit-PatchSet: 7
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)