You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/25 16:21:22 UTC
[GitHub] [airflow] XD-DENG commented on a change in pull request #13312: Updates IMAGES documentation to reflect Airflow 2.0 changes
XD-DENG commented on a change in pull request #13312:
URL: https://github.com/apache/airflow/pull/13312#discussion_r548889666
##########
File path: IMAGES.rst
##########
@@ -39,19 +39,20 @@ The images are named as follows:
where:
-* ``BRANCH_OR_TAG`` - branch or tag used when creating the image. Examples: ``master``, ``v1-10-test``, ``1.10.14``
- The ``master`` and ``v1-10-test`` labels are built from branches so they change over time. The ``1.10.*`` and in
- the future ``2.*`` labels are build from git tags and they are "fixed" once built.
-* ``PYTHON_MAJOR_MINOR_VERSION`` - version of python used to build the image. Examples: ``3.5``, ``3.7``
+* ``BRANCH_OR_TAG`` - branch or tag used when creating the image. Examples: ``master``,
+ ``v2-0-test``, ``v1-10-test``, ``2.0.0``. The ``master``, ``v1-10-test`` ``v2-0-test`` labels are
+ built from branches so they change over time. The ``1.10.*`` and ``2.*`` labels are build from git tags
+ and they are "fixed" once built.
+* ``PYTHON_MAJOR_MINOR_VERSION`` - version of python used to build the image. Examples: ``3.6``, ``3.7``,
+ ``3.8``
Review comment:
This seems not rendered correctly
##########
File path: IMAGES.rst
##########
@@ -39,19 +39,20 @@ The images are named as follows:
where:
-* ``BRANCH_OR_TAG`` - branch or tag used when creating the image. Examples: ``master``, ``v1-10-test``, ``1.10.14``
- The ``master`` and ``v1-10-test`` labels are built from branches so they change over time. The ``1.10.*`` and in
- the future ``2.*`` labels are build from git tags and they are "fixed" once built.
-* ``PYTHON_MAJOR_MINOR_VERSION`` - version of python used to build the image. Examples: ``3.5``, ``3.7``
+* ``BRANCH_OR_TAG`` - branch or tag used when creating the image. Examples: ``master``,
+ ``v2-0-test``, ``v1-10-test``, ``2.0.0``. The ``master``, ``v1-10-test`` ``v2-0-test`` labels are
+ built from branches so they change over time. The ``1.10.*`` and ``2.*`` labels are build from git tags
Review comment:
```suggestion
built from branches so they change over time. The ``1.10.*`` and ``2.*`` labels are built from git tags
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org