You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2019/07/30 19:23:47 UTC

svn commit: r1864022 - /pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/imageio/ImageIOUtil.java

Author: tilman
Date: Tue Jul 30 19:23:47 2019
New Revision: 1864022

URL: http://svn.apache.org/viewvc?rev=1864022&view=rev
Log:
PDFBOX-4071: SonarQube fix

Modified:
    pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/imageio/ImageIOUtil.java

Modified: pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/imageio/ImageIOUtil.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/imageio/ImageIOUtil.java?rev=1864022&r1=1864021&r2=1864022&view=diff
==============================================================================
--- pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/imageio/ImageIOUtil.java (original)
+++ pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/imageio/ImageIOUtil.java Tue Jul 30 19:23:47 2019
@@ -278,8 +278,8 @@ public final class ImageIOUtil
                 // TIFF metadata
                 TIFFUtil.updateMetadata(metadata, image, dpi);
             }
-            else if ("jpeg".equals(formatName.toLowerCase())
-                    || "jpg".equals(formatName.toLowerCase()))
+            else if ("jpeg".equalsIgnoreCase(formatName)
+                    || "jpg".equalsIgnoreCase(formatName))
             {
                 // This segment must be run before other meta operations,
                 // or else "IIOInvalidTreeException: Invalid node: app0JFIF"
@@ -348,7 +348,7 @@ public final class ImageIOUtil
         // PNG writer doesn't conform to the spec which is
         // "The width of a pixel, in millimeters"
         // but instead counts the pixels per millimeter
-        float res = "PNG".equals(formatName.toUpperCase())
+        float res = "PNG".equalsIgnoreCase(formatName)
                     ? dpi / 25.4f
                     : 25.4f / dpi;