[GitHub] brodybits edited a comment on issue #572: Resolve issue with plugin target-dir="app*" subdirs

[GitBox <gi...@apache.org>]

brodybits edited a comment on issue #572: Resolve issue with plugin target-dir="app*" subdirs
URL: https://github.com/apache/cordova-android/pull/572#issuecomment-441036462
 
 
   ## Tested in a new Cordova project
   
   ### reproduced using cordova-android@latest (7.1.3)
   
   * `cordova platform add android@latest`
   * `cordova plugin add cordova-plugin-inappbrowser`
   
   then the plugin Java files were incorrectly installed in the following relative directory path: `platforms/android/src/org/apache/cordova/inappbrowser`
   
   ### Verified on proposed bug fix
   
   * `cordova platform add https://github.com/brodybits/cordova-android#app-subdir-bugfix` (based on the `master` branch, which includes bleeding-edge updates for Cordova 9)
   * `cordova plugin add cordova-plugin-inappbrowser`
   
   then the plugin Java files are correctly installed in the following relative directory path: `platforms/android/app/src/main/java/org/apache/cordova/inappbrowser`
   
   I also tested that `cordova-plugin-inappbrowser` Java files install correctly on cordova-android@7.1.2.
   
   Merging now.
   
   P.S. Some additional testing done after merge:
   
   Tried `cordova-plugin-badge` with 7.1.3, `https://github.com/apache/cordova-android#master`, and 7.1.2
   
   Reproduced issue on 7.1.3, resolved on `https://github.com/apache/cordova-android#master`, no issue observed on 7.1.2.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org