You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/06/02 09:28:56 UTC
[GitHub] [skywalking-java] xjs1919 opened a new pull request, #190: string "/eureka" should match pattern "/eureka/*" or "/eureka/**"
xjs1919 opened a new pull request, #190:
URL: https://github.com/apache/skywalking-java/pull/190
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👇 ====
### Add an agent plugin to support <framework name>
- [ ] Add a test case for the new plugin, refer to [the doc](https://github.com/apache/skywalking-java/blob/main/docs/en/setup/service-agent/java-agent/Plugin-test.md)
- [ ] Add a component id in [the component-libraries.yml](https://github.com/apache/skywalking/blob/master/oap-server/server-starter/src/main/resources/component-libraries.yml)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking-java/blob/main/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
### string "/eureka" should match pattern "/eureka/*" or "/eureka/**"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #190: string "/eureka" should match pattern "/eureka/*" or "/eureka/**"
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #190:
URL: https://github.com/apache/skywalking-java/pull/190#issuecomment-1144654736
@devkanro @DominikHubacek Could you review this one as you both were involved in this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #190: string "/eureka" should match pattern "/eureka/*" or "/eureka/**"
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #190:
URL: https://github.com/apache/skywalking-java/pull/190#issuecomment-1144682381
You just need to update the branch, don't have to create a new PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xjs1919 commented on pull request #190: string "/eureka" should match pattern "/eureka/*" or "/eureka/**"
Posted by GitBox <gi...@apache.org>.
xjs1919 commented on PR #190:
URL: https://github.com/apache/skywalking-java/pull/190#issuecomment-1144679852
checkstyle violation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xjs1919 closed pull request #190: string "/eureka" should match pattern "/eureka/*" or "/eureka/**"
Posted by GitBox <gi...@apache.org>.
xjs1919 closed pull request #190: string "/eureka" should match pattern "/eureka/*" or "/eureka/**"
URL: https://github.com/apache/skywalking-java/pull/190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #190: string "/eureka" should match pattern "/eureka/*" or "/eureka/**"
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #190:
URL: https://github.com/apache/skywalking-java/pull/190#issuecomment-1144661064
> 2022-06-02T09:38:07.3271683Z [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0:check (validate) on project apm-trace-ignore-plugin: You have 8 Checkstyle violations. -> [Help 1]
@xjs1919 You don't follow style file we provided in the root. Please fix them and do `mvn install` passed including `mvn verify`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org