You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Eli Collins (JIRA)" <ji...@apache.org> on 2011/08/08 05:51:27 UTC
[jira] [Created] (HDFS-2233) WebUI doesn't handle file names with
";" and "+" characters
WebUI doesn't handle file names with ";" and "+" characters
-----------------------------------------------------------
Key: HDFS-2233
URL: https://issues.apache.org/jira/browse/HDFS-2233
Project: Hadoop HDFS
Issue Type: Bug
Components: name-node
Affects Versions: 0.23.0
Reporter: Eli Collins
Fix For: 0.23.0
The web UI can't handle paths like "/foo;bar" and "/foo+bar", ie that contain reserved URI characters.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HDFS-2233) WebUI doesn't handle file names with
";" and "+" characters
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins reassigned HDFS-2233:
---------------------------------
Assignee: Eli Collins
> WebUI doesn't handle file names with ";" and "+" characters
> -----------------------------------------------------------
>
> Key: HDFS-2233
> URL: https://issues.apache.org/jira/browse/HDFS-2233
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.23.0
>
> Attachments: hdfs-2233-1.patch
>
>
> The web UI can't handle paths like "/foo;bar" and "/foo+bar", ie that contain reserved URI characters.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2233) Add WebUI tests with URI reserved
chars in the path and filename
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085359#comment-13085359 ]
Hudson commented on HDFS-2233:
------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #835 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/835/])
HDFS-2233. Add WebUI tests with URI reserved chars. Contributed by Eli Collins
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1158025
Files :
* /hadoop/common/trunk/hdfs/CHANGES.txt
* /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/datanode/TestDatanodeJsp.java
> Add WebUI tests with URI reserved chars in the path and filename
> ----------------------------------------------------------------
>
> Key: HDFS-2233
> URL: https://issues.apache.org/jira/browse/HDFS-2233
> Project: Hadoop HDFS
> Issue Type: Test
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.23.0
>
> Attachments: hdfs-2233-1.patch, hdfs-2233-2.patch
>
>
> The web UI tests should cover paths where the path and filenames contain URI reserved characters. Ie Web UI coverage for HDFS-2235.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2233) Add WebUI tests with URI reserved
chars in the path and filename
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085318#comment-13085318 ]
Aaron T. Myers commented on HDFS-2233:
--------------------------------------
+1, patch looks good to me.
> Add WebUI tests with URI reserved chars in the path and filename
> ----------------------------------------------------------------
>
> Key: HDFS-2233
> URL: https://issues.apache.org/jira/browse/HDFS-2233
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.23.0
>
> Attachments: hdfs-2233-1.patch, hdfs-2233-2.patch
>
>
> The web UI tests should cover paths where the path and filenames contain URI reserved characters. Ie Web UI coverage for HDFS-2235.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2233) Add WebUI tests with URI reserved
chars in the path and filename
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-2233:
------------------------------
Issue Type: Test (was: Bug)
> Add WebUI tests with URI reserved chars in the path and filename
> ----------------------------------------------------------------
>
> Key: HDFS-2233
> URL: https://issues.apache.org/jira/browse/HDFS-2233
> Project: Hadoop HDFS
> Issue Type: Test
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.23.0
>
> Attachments: hdfs-2233-1.patch, hdfs-2233-2.patch
>
>
> The web UI tests should cover paths where the path and filenames contain URI reserved characters. Ie Web UI coverage for HDFS-2235.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2233) Add WebUI tests with URI reserved
chars in the path and filename
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085367#comment-13085367 ]
Hudson commented on HDFS-2233:
------------------------------
Integrated in Hadoop-Common-trunk-Commit #744 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/744/])
HDFS-2233. Add WebUI tests with URI reserved chars. Contributed by Eli Collins
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1158025
Files :
* /hadoop/common/trunk/hdfs/CHANGES.txt
* /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/datanode/TestDatanodeJsp.java
> Add WebUI tests with URI reserved chars in the path and filename
> ----------------------------------------------------------------
>
> Key: HDFS-2233
> URL: https://issues.apache.org/jira/browse/HDFS-2233
> Project: Hadoop HDFS
> Issue Type: Test
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.23.0
>
> Attachments: hdfs-2233-1.patch, hdfs-2233-2.patch
>
>
> The web UI tests should cover paths where the path and filenames contain URI reserved characters. Ie Web UI coverage for HDFS-2235.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2233) Add WebUI tests with URI reserved
chars in the path and filename
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-2233:
------------------------------
Hadoop Flags: [Reviewed]
Status: Patch Available (was: Open)
Thanks atm! I've committed this.
> Add WebUI tests with URI reserved chars in the path and filename
> ----------------------------------------------------------------
>
> Key: HDFS-2233
> URL: https://issues.apache.org/jira/browse/HDFS-2233
> Project: Hadoop HDFS
> Issue Type: Test
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.23.0
>
> Attachments: hdfs-2233-1.patch, hdfs-2233-2.patch
>
>
> The web UI tests should cover paths where the path and filenames contain URI reserved characters. Ie Web UI coverage for HDFS-2235.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2233) Add WebUI tests with URI reserved
chars in the path and filename
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-2233:
------------------------------
Description: The web UI tests should cover paths where the path and filenames contain URI reserved characters. Ie Web UI coverage for HDFS-2235. (was: The web UI can't handle paths like "/foo;bar" and "/foo+bar", ie that contain reserved URI characters. )
Summary: Add WebUI tests with URI reserved chars in the path and filename (was: WebUI doesn't handle file names with ";" and "+" characters)
HDFS-2235 fixed this issue, we just need to add more tests.
> Add WebUI tests with URI reserved chars in the path and filename
> ----------------------------------------------------------------
>
> Key: HDFS-2233
> URL: https://issues.apache.org/jira/browse/HDFS-2233
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.23.0
>
> Attachments: hdfs-2233-1.patch, hdfs-2233-2.patch
>
>
> The web UI tests should cover paths where the path and filenames contain URI reserved characters. Ie Web UI coverage for HDFS-2235.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2233) Add WebUI tests with URI reserved
chars in the path and filename
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-2233:
------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Add WebUI tests with URI reserved chars in the path and filename
> ----------------------------------------------------------------
>
> Key: HDFS-2233
> URL: https://issues.apache.org/jira/browse/HDFS-2233
> Project: Hadoop HDFS
> Issue Type: Test
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.23.0
>
> Attachments: hdfs-2233-1.patch, hdfs-2233-2.patch
>
>
> The web UI tests should cover paths where the path and filenames contain URI reserved characters. Ie Web UI coverage for HDFS-2235.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2233) Add WebUI tests with URI reserved
chars in the path and filename
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-2233:
------------------------------
Attachment: hdfs-2233-2.patch
Patch attached.
> Add WebUI tests with URI reserved chars in the path and filename
> ----------------------------------------------------------------
>
> Key: HDFS-2233
> URL: https://issues.apache.org/jira/browse/HDFS-2233
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.23.0
>
> Attachments: hdfs-2233-1.patch, hdfs-2233-2.patch
>
>
> The web UI tests should cover paths where the path and filenames contain URI reserved characters. Ie Web UI coverage for HDFS-2235.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2233) Add WebUI tests with URI reserved
chars in the path and filename
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085352#comment-13085352 ]
Eli Collins commented on HDFS-2233:
-----------------------------------
{noformat}
+1 overall.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 14 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 system test framework. The patch passed system test framework compile.
{noformat}
And TestDatanodeJsp passes.
> Add WebUI tests with URI reserved chars in the path and filename
> ----------------------------------------------------------------
>
> Key: HDFS-2233
> URL: https://issues.apache.org/jira/browse/HDFS-2233
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.23.0
>
> Attachments: hdfs-2233-1.patch, hdfs-2233-2.patch
>
>
> The web UI tests should cover paths where the path and filenames contain URI reserved characters. Ie Web UI coverage for HDFS-2235.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2233) WebUI doesn't handle file names with
";" and "+" characters
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-2233:
------------------------------
Attachment: hdfs-2233-1.patch
Patch attached adds tests to TestDatanodeJsp that illustrate this. The two tests commented out fail.
> WebUI doesn't handle file names with ";" and "+" characters
> -----------------------------------------------------------
>
> Key: HDFS-2233
> URL: https://issues.apache.org/jira/browse/HDFS-2233
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Eli Collins
> Fix For: 0.23.0
>
> Attachments: hdfs-2233-1.patch
>
>
> The web UI can't handle paths like "/foo;bar" and "/foo+bar", ie that contain reserved URI characters.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2233) Add WebUI tests with URI reserved
chars in the path and filename
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085503#comment-13085503 ]
Hudson commented on HDFS-2233:
------------------------------
Integrated in Hadoop-Hdfs-trunk #752 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/752/])
HDFS-2233. Add WebUI tests with URI reserved chars. Contributed by Eli Collins
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1158025
Files :
* /hadoop/common/trunk/hdfs/CHANGES.txt
* /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/datanode/TestDatanodeJsp.java
> Add WebUI tests with URI reserved chars in the path and filename
> ----------------------------------------------------------------
>
> Key: HDFS-2233
> URL: https://issues.apache.org/jira/browse/HDFS-2233
> Project: Hadoop HDFS
> Issue Type: Test
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.23.0
>
> Attachments: hdfs-2233-1.patch, hdfs-2233-2.patch
>
>
> The web UI tests should cover paths where the path and filenames contain URI reserved characters. Ie Web UI coverage for HDFS-2235.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira