You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/02/15 11:18:39 UTC

[GitHub] [arrow] alamb commented on a change in pull request #9493: ARROW-11624: [Rust] Move Arrow benchmarks to its own crate

alamb commented on a change in pull request #9493:
URL: https://github.com/apache/arrow/pull/9493#discussion_r576119636



##########
File path: rust/arrow/Cargo.toml
##########
@@ -63,85 +62,8 @@ prettyprint = ["prettytable-rs"]
 memory-check = []
 
 [dev-dependencies]
-criterion = "0.3"

Review comment:
       I guess I was imagining something more like adding a 
   ```
   [features]
   benches = ["criterion"]
   ```
   
   So then if one wanted to have the benches built they could run a command like `cargo bench --features benches ` or something
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org