You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/05/09 19:08:46 UTC

[kudu-CR] thread: enable stack watchdog for thread creation

Hello Adar Dembo,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/3005

to review the following change.

Change subject: thread: enable stack watchdog for thread creation
......................................................................

thread: enable stack watchdog for thread creation

In stress workloads, I see warnings fairly frequently that thread creation
is slow (on the order of 1 second). It's not clear what triggers this
behavior, yet, so this patch adds a stack watchdog to grab the kernel stack
during slow thread creation.

The only subtelty here is that starting the stack watchdog itself requires
starting a thread, so to avoid a self-deadlock, we need to start the
watchdog thread with a flag disabling watching itself.

Change-Id: Ia423084d01716e5d4884d17cdf836a43489a6ebc
---
M src/kudu/util/kernel_stack_watchdog.cc
M src/kudu/util/kernel_stack_watchdog.h
M src/kudu/util/thread.cc
M src/kudu/util/thread.h
4 files changed, 39 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/3005/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3005
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia423084d01716e5d4884d17cdf836a43489a6ebc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>