You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by dhams <gi...@git.apache.org> on 2016/02/09 14:52:44 UTC
[GitHub] cordova-plugin-splashscreen pull request: Fixed doccument issue
GitHub user dhams opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/80
Fixed doccument issue
Changed miss leaded document.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Accenture/cordova-plugin-splashscreen CB-6498
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-splashscreen/pull/80.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #80
----
commit 733cfbcd7a239df990158717f92ec75f78b3975d
Author: Sharma, Dharmendra G <dh...@accenture.com>
Date: 2016-02-09T13:23:53Z
Fixed doccument issue
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Fixed doccument issue
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/80#discussion_r52310332
--- Diff: README.md ---
@@ -123,6 +123,8 @@ window.setTimeout(function () {
}, splashDuration - fadeDuration);
```
+### iOS Quirks
--- End diff --
Spinner is supported for Android too so this is not an iOS-only Quirk anymore.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Fixed doccument issue
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/80#discussion_r52312032
--- Diff: README.md ---
@@ -123,6 +123,8 @@ window.setTimeout(function () {
}, splashDuration - fadeDuration);
```
+### iOS Quirks
--- End diff --
@dhams, looks like you have added a few extra lines - compare with the current version in master: https://github.com/apache/cordova-plugin-splashscreen/blame/master/README.md#L94
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Fixed doccument issue
Posted by dhams <gi...@git.apache.org>.
Github user dhams commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/80#discussion_r52311417
--- Diff: README.md ---
@@ -123,6 +123,8 @@ window.setTimeout(function () {
}, splashDuration - fadeDuration);
```
+### iOS Quirks
--- End diff --
@daserge I have just changed document for Android only. You can see by expanding those full changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Fixed doccument issue
Posted by dhams <gi...@git.apache.org>.
Github user dhams closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/80
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org