[jira] [Commented] (THRIFT-1627) compiler built using compilers.vcxproj cannot be used to build some test .thrift files

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-1627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293941#comment-13293941 ] 

Hudson commented on THRIFT-1627:
--------------------------------

Integrated in Thrift #499 (See [https://builds.apache.org/job/Thrift/499/])
    THRIFT-1627 compiler built using compilers.vcxproj cannot be used to build some test .thrift files
Patch: Andrew Cox (Revision 1349524)

     Result = SUCCESS
roger : http://svn.apache.org/viewvc/?view=rev&rev=1349524
Files : 
* /thrift/trunk/compiler/cpp/compiler.vcxproj
* /thrift/trunk/compiler/cpp/compiler.vcxproj.filters
* /thrift/trunk/compiler/cpp/src/generate/t_delphi_generator.cc
* /thrift/trunk/compiler/cpp/src/thriftl.ll
* /thrift/trunk/compiler/cpp/src/windows/config.h

                
> compiler built using compilers.vcxproj cannot be used to build some test .thrift files
> --------------------------------------------------------------------------------------
>
>                 Key: THRIFT-1627
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1627
>             Project: Thrift
>          Issue Type: Bug
>          Components: Build Process
>    Affects Versions: 0.9
>         Environment: Windows, using Visual C++ to build compiler
>            Reporter: Andrew Cox
>            Assignee: Andrew Cox
>            Priority: Minor
>             Fix For: 0.9
>
>         Attachments: thrift-windows-build-fixes.patch
>
>
> I tried to setup an environment on Windows. Rather than use a pre-built thrift.exe compiler, I built the compiler from source using Visual C++ (via compiler.vcxproj). While the compiler builds successfully, it is lacking generators for Delphi and D languages.
> When the compiler encounters a namespace directive in a .thrift file for a language, and it doesn't have a generator for that language, it throws an error.
> Therefore, this change adds the D and Delphi generators to the VC++ project.
> Additionally, some test thrift files use a very large integer constant (10 billion, too big for 32 bits). The windows-built compiler had strtoll #define'd to strtol, so it could not handle this large integer, so the test failed. This change defines strtoll as _stroi64, the VC++ equivalent, to fix that issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira