You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@daffodil.apache.org by GitBox <gi...@apache.org> on 2018/08/14 11:31:21 UTC

[GitHub] stevedlawrence commented on a change in pull request #99: Fix missing checks for minOccurs after zero occurrences.

stevedlawrence commented on a change in pull request #99: Fix missing checks for minOccurs after zero occurrences.
URL: https://github.com/apache/incubator-daffodil/pull/99#discussion_r209913905
 
 

 ##########
 File path: daffodil-test/src/test/scala/org/apache/daffodil/section16/array_optional_elem/TestArrayOptionalElemNew.scala
 ##########
 @@ -18,40 +18,28 @@
 package org.apache.daffodil.section16.array_optional_elem
 
 import org.apache.daffodil.util._
-import org.apache.daffodil.tdml.DFDLTestSuite
+import org.apache.daffodil.tdml.Runner
 import org.junit.AfterClass
+import org.junit.Test
 
 object TestArrayOptionalElemNew {
 
 Review comment:
   We don't really use the scala-new thing anymore. I think it's reasonable to put this in TestArrayOptionalElem.scala. These *New.scala files should probably be deleted with their content moved to the not New files at some point. Maybe delete this file while you're at it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services