You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2019/08/06 19:28:11 UTC
Review Request 71240: Added a `dist` target to the cmake build.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71240/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Till Toenshoff.
Repository: mesos
Description
-------
This patch adds a `dist` target to the cmake build, analogous to the
target provided by the autotools build.
While cmake already provides a `package_source` target to create a
source archive it does not take care of only including relevant files,
but instead adds all files to the archive, e.g., including build or
backup files which should not be part of a release. For that reason this
patch introduces a script which performs a temporary `git clone` from
the checked out git repository and creates the archive from that clean
tree.
This patch also removes a hardcoded list of ignored files which was
by design not exhaustive.
Diffs
-----
CMakeLists.txt 65bfbac0e2b6aec26a6d98ff96615661210ceac2
cmake/dist.sh PRE-CREATION
Diff: https://reviews.apache.org/r/71240/diff/1/
Testing
-------
`ninja dist` produces a tarball, no artifacts left around but tarball.
Thanks,
Benjamin Bannier
Re: Review Request 71240: Added a `dist` target to the cmake build.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71240/#review217578
-----------------------------------------------------------
cmake/dist.sh
Lines 37 (patched)
<https://reviews.apache.org/r/71240/#comment304853>
s/Sucessfully/Successfully/
- Till Toenshoff
On Sept. 3, 2019, 1:52 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71240/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2019, 1:52 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a `dist` target to the cmake build, analogous to the
> target provided by the autotools build.
>
> While cmake already provides a `package_source` target to create a
> source archive it does not take care of only including relevant files,
> but instead adds all files to the archive, e.g., including build or
> backup files which should not be part of a release. For that reason this
> patch introduces a script which performs a temporary `git clone` from
> the checked out git repository and creates the archive from that clean
> tree.
>
> This patch also removes a hardcoded list of ignored files which was
> by design not exhaustive.
>
>
> Diffs
> -----
>
> CMakeLists.txt dc50dd457585c14a456ca710da4a16a0d45ef17a
> cmake/dist.sh PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/71240/diff/2/
>
>
> Testing
> -------
>
> `ninja dist` produces a tarball, no artifacts left around but tarball.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71240: Added a `dist` target to the cmake build.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71240/#review217577
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On Sept. 3, 2019, 1:52 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71240/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2019, 1:52 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a `dist` target to the cmake build, analogous to the
> target provided by the autotools build.
>
> While cmake already provides a `package_source` target to create a
> source archive it does not take care of only including relevant files,
> but instead adds all files to the archive, e.g., including build or
> backup files which should not be part of a release. For that reason this
> patch introduces a script which performs a temporary `git clone` from
> the checked out git repository and creates the archive from that clean
> tree.
>
> This patch also removes a hardcoded list of ignored files which was
> by design not exhaustive.
>
>
> Diffs
> -----
>
> CMakeLists.txt dc50dd457585c14a456ca710da4a16a0d45ef17a
> cmake/dist.sh PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/71240/diff/2/
>
>
> Testing
> -------
>
> `ninja dist` produces a tarball, no artifacts left around but tarball.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71240: Added a `dist` target to the cmake build.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71240/#review217549
-----------------------------------------------------------
I compared the produced tarballs:
- 25 files only in autotools tarball:
mesos-1.10.0/3rdparty/libprocess/3rdparty/Makefile.in
mesos-1.10.0/3rdparty/libprocess/include/Makefile.in
mesos-1.10.0/3rdparty/libprocess/Makefile.in
mesos-1.10.0/3rdparty/Makefile.in
mesos-1.10.0/3rdparty/stout/3rdparty/Makefile.in
mesos-1.10.0/3rdparty/stout/include/Makefile.in
mesos-1.10.0/3rdparty/stout/Makefile.in
mesos-1.10.0/aclocal.m4
mesos-1.10.0/ar-lib
mesos-1.10.0/compile
mesos-1.10.0/config.guess
mesos-1.10.0/config.sub
mesos-1.10.0/configure
mesos-1.10.0/depcomp
mesos-1.10.0/install-sh
mesos-1.10.0/ltmain.sh
mesos-1.10.0/m4/libtool.m4
mesos-1.10.0/m4/lt~obsolete.m4
mesos-1.10.0/m4/ltoptions.m4
mesos-1.10.0/m4/ltsugar.m4
mesos-1.10.0/m4/ltversion.m4
mesos-1.10.0/Makefile.in
mesos-1.10.0/missing
mesos-1.10.0/src/common/git_version.hpp
mesos-1.10.0/src/Makefile.in
- 615 files only in cmake tarball:
mesos-1.10.0/3rdparty/boost.md
mesos-1.10.0/3rdparty/bzip2-1.0.6.tar.gz
mesos-1.10.0/3rdparty/cmake/
mesos-1.10.0/3rdparty/cmake/cotire.cmake
mesos-1.10.0/3rdparty/cmake/External.cmake
mesos-1.10.0/3rdparty/cmake/FindLEVELDB.cmake
mesos-1.10.0/3rdparty/cmake/FindLIBARCHIVE.cmake
mesos-1.10.0/3rdparty/cmake/FindLIBEVENT.cmake
mesos-1.10.0/3rdparty/cmake/FindLIBSECCOMP.cmake
mesos-1.10.0/3rdparty/CMakeLists.txt
mesos-1.10.0/3rdparty/cmake/PatchCommand.cmake
mesos-1.10.0/3rdparty/cmake/Versions.cmake
mesos-1.10.0/3rdparty/concurrentqueue.md
mesos-1.10.0/3rdparty/grpc.md
mesos-1.10.0/3rdparty/http-parser/
mesos-1.10.0/3rdparty/http-parser/CMakeLists.txt.template
mesos-1.10.0/3rdparty/libprocess/bootstrap
mesos-1.10.0/3rdparty/libprocess/CMakeLists.txt
mesos-1.10.0/3rdparty/libprocess/configure.ac
mesos-1.10.0/3rdparty/libprocess/examples/CMakeLists.txt
mesos-1.10.0/3rdparty/libprocess/include/process/windows/
mesos-1.10.0/3rdparty/libprocess/include/process/windows/jobobject.hpp
mesos-1.10.0/3rdparty/libprocess/LICENSE
mesos-1.10.0/3rdparty/libprocess/m4/
mesos-1.10.0/3rdparty/libprocess/m4/ax_append_compile_flags.m4
mesos-1.10.0/3rdparty/libprocess/m4/ax_append_flag.m4
mesos-1.10.0/3rdparty/libprocess/m4/ax_check_compile_flag.m4
mesos-1.10.0/3rdparty/libprocess/m4/ax_compare_version.m4
mesos-1.10.0/3rdparty/libprocess/m4/ax_compiler_vendor.m4
mesos-1.10.0/3rdparty/libprocess/m4/ax_compiler_version.m4
mesos-1.10.0/3rdparty/libprocess/m4/ax_cxx_compile_stdcxx.m4
mesos-1.10.0/3rdparty/libprocess/m4/ax_pthread.m4
mesos-1.10.0/3rdparty/libprocess/m4/ax_require_defined.m4
mesos-1.10.0/3rdparty/libprocess/m4/libevent.m4
mesos-1.10.0/3rdparty/libprocess/README.md
mesos-1.10.0/3rdparty/libprocess/src/CMakeLists.txt
mesos-1.10.0/3rdparty/libprocess/src/tests/CMakeLists.txt
mesos-1.10.0/3rdparty/libprocess/src/tests/test_echo.cpp
mesos-1.10.0/3rdparty/libprocess/src/windows/
mesos-1.10.0/3rdparty/libprocess/src/windows/event_loop.cpp
mesos-1.10.0/3rdparty/libprocess/src/windows/event_loop.hpp
mesos-1.10.0/3rdparty/libprocess/src/windows/io.cpp
mesos-1.10.0/3rdparty/libprocess/src/windows/libwinio.cpp
mesos-1.10.0/3rdparty/libprocess/src/windows/libwinio.hpp
mesos-1.10.0/3rdparty/libprocess/src/windows/poll_socket.cpp
mesos-1.10.0/3rdparty/libprocess/src/windows/subprocess.cpp
mesos-1.10.0/3rdparty/libprocess/src/windows/subprocess.hpp
mesos-1.10.0/3rdparty/patch.exe.manifest
mesos-1.10.0/3rdparty/protobuf.md
mesos-1.10.0/3rdparty/rapidjson.md
mesos-1.10.0/3rdparty/README.md
mesos-1.10.0/3rdparty/stout/bootstrap
mesos-1.10.0/3rdparty/stout/cmake/
mesos-1.10.0/3rdparty/stout/cmake/FindAPR.cmake
mesos-1.10.0/3rdparty/stout/cmake/FindPackageHelper.cmake
mesos-1.10.0/3rdparty/stout/cmake/FindSVN.cmake
mesos-1.10.0/3rdparty/stout/CMakeLists.txt
mesos-1.10.0/3rdparty/stout/configure.ac
mesos-1.10.0/3rdparty/stout/include/stout/internal/windows/inherit.hpp
mesos-1.10.0/3rdparty/stout/include/stout/os/sunos.hpp
mesos-1.10.0/3rdparty/stout/LICENSE
mesos-1.10.0/3rdparty/stout/m4/
mesos-1.10.0/3rdparty/stout/m4/ax_append_compile_flags.m4
mesos-1.10.0/3rdparty/stout/m4/ax_append_flag.m4
mesos-1.10.0/3rdparty/stout/m4/ax_check_compile_flag.m4
mesos-1.10.0/3rdparty/stout/m4/ax_compare_version.m4
mesos-1.10.0/3rdparty/stout/m4/ax_compiler_vendor.m4
mesos-1.10.0/3rdparty/stout/m4/ax_compiler_version.m4
mesos-1.10.0/3rdparty/stout/m4/ax_cxx_compile_stdcxx.m4
mesos-1.10.0/3rdparty/stout/m4/ax_pthread.m4
mesos-1.10.0/3rdparty/stout/m4/ax_require_defined.m4
mesos-1.10.0/3rdparty/stout/README.md
mesos-1.10.0/3rdparty/stout/tests/CMakeLists.txt
mesos-1.10.0/3rdparty/xz-5.2.3-modified.tar.gz
mesos-1.10.0/3rdparty/xz.README.txt
mesos-1.10.0/bootstrap.bat
mesos-1.10.0/CHANGELOG
mesos-1.10.0/cmake/
mesos-1.10.0/cmake/CompilationConfigure.cmake
mesos-1.10.0/cmake/distcheck.sh
mesos-1.10.0/cmake/dist.sh
mesos-1.10.0/CMakeLists.txt
mesos-1.10.0/cmake/MesosConfigure.cmake
mesos-1.10.0/CONTRIBUTING.md
mesos-1.10.0/docs/
mesos-1.10.0/docs/advanced-contribution.md
mesos-1.10.0/docs/agent-recovery.md
mesos-1.10.0/docs/allocation-module.md
mesos-1.10.0/docs/api-client-libraries.md
mesos-1.10.0/docs/app-framework-development-guide.md
mesos-1.10.0/docs/architecture.md
mesos-1.10.0/docs/attributes-resources.md
mesos-1.10.0/docs/authentication.md
mesos-1.10.0/docs/authorization.md
mesos-1.10.0/docs/beginner-contribution.md
mesos-1.10.0/docs/binary-packages.md
mesos-1.10.0/docs/building.md
mesos-1.10.0/docs/clang-format.md
mesos-1.10.0/docs/cli.md
mesos-1.10.0/docs/cmake-examples.md
mesos-1.10.0/docs/cmake.md
mesos-1.10.0/docs/cni.md
mesos-1.10.0/docs/committer-candidate-guidelines.md
mesos-1.10.0/docs/committers.md
mesos-1.10.0/docs/committing.md
mesos-1.10.0/docs/configuration/
mesos-1.10.0/docs/configuration/agent.md
mesos-1.10.0/docs/configuration/autotools.md
mesos-1.10.0/docs/configuration/cmake.md
mesos-1.10.0/docs/configuration/libprocess.md
mesos-1.10.0/docs/configuration/master-and-agent.md
mesos-1.10.0/docs/configuration/master.md
mesos-1.10.0/docs/configuration.md
mesos-1.10.0/docs/container-image.md
mesos-1.10.0/docs/containerizer-internals.md
mesos-1.10.0/docs/containerizers.md
mesos-1.10.0/docs/container-volume.md
mesos-1.10.0/docs/contributors.yaml
mesos-1.10.0/docs/cquery.md
mesos-1.10.0/docs/csi.md
mesos-1.10.0/docs/c++-style-guide.md
mesos-1.10.0/docs/deploy-scripts.md
mesos-1.10.0/docs/design-docs.md
mesos-1.10.0/docs/developer-guide.md
mesos-1.10.0/docs/docker-containerizer.md
mesos-1.10.0/docs/documentation-guide.md
mesos-1.10.0/docs/downgrades.md
mesos-1.10.0/docs/doxygen-style-guide.md
mesos-1.10.0/docs/effective-code-reviewing.md
mesos-1.10.0/docs/engineering-principles-and-practices.md
mesos-1.10.0/docs/examples/
mesos-1.10.0/docs/examples/acls_template.json
mesos-1.10.0/docs/examples/seccomp_default.json
mesos-1.10.0/docs/executor-http-api.md
mesos-1.10.0/docs/fault-domains.md
mesos-1.10.0/docs/fetcher-cache-internals.md
mesos-1.10.0/docs/fetcher.md
mesos-1.10.0/docs/framework-rate-limiting.md
mesos-1.10.0/docs/frameworks.md
mesos-1.10.0/docs/gpu-support.md
mesos-1.10.0/docs/health-checks.md
mesos-1.10.0/docs/high-availability-framework-guide.md
mesos-1.10.0/docs/high-availability.md
mesos-1.10.0/docs/home.md
mesos-1.10.0/docs/images/
mesos-1.10.0/docs/images/1.3-1.5_master_failover_no_history.png
mesos-1.10.0/docs/images/1.3-1.5_master_failover_with_history.png
mesos-1.10.0/docs/images/1.3-1.5_v1_json_state_query_latency.png
mesos-1.10.0/docs/images/architecture3.jpg
mesos-1.10.0/docs/images/architecture-example.jpg
mesos-1.10.0/docs/images/containerizer_isolator_api.png
mesos-1.10.0/docs/images/csi-architecture.png
mesos-1.10.0/docs/images/docker-volume-isolator.png
mesos-1.10.0/docs/images/ec_kill_seqdiag.png
mesos-1.10.0/docs/images/ec_launch_seqdiag.png
mesos-1.10.0/docs/images/ec_lifecycle_seqdiag.png
mesos-1.10.0/docs/images/ec_orphan_seqdiag.png
mesos-1.10.0/docs/images/ec_recover_seqdiag.png
mesos-1.10.0/docs/images/fetch_components.jpg
mesos-1.10.0/docs/images/fetch_evict1.jpg
mesos-1.10.0/docs/images/fetch_evict2.jpg
mesos-1.10.0/docs/images/fetch_evict3.jpg
mesos-1.10.0/docs/images/fetch_flow.jpg
mesos-1.10.0/docs/images/fetch_state.jpg
mesos-1.10.0/docs/images/log-architecture.png
mesos-1.10.0/docs/images/log-cluster.png
mesos-1.10.0/docs/images/maintenance-primitives-modes.png
mesos-1.10.0/docs/images/networking-architecture.png
mesos-1.10.0/docs/images/oversubscription-overview.jpg
mesos-1.10.0/docs/isolators/
mesos-1.10.0/docs/isolators/cgroups-blkio.md
mesos-1.10.0/docs/isolators/cgroups-cpu.md
mesos-1.10.0/docs/isolators/cgroups-devices.md
mesos-1.10.0/docs/isolators/cgroups-net-cls.md
mesos-1.10.0/docs/isolators/disk-du.md
mesos-1.10.0/docs/isolators/disk-xfs.md
mesos-1.10.0/docs/isolators/docker-runtime.md
mesos-1.10.0/docs/isolators/docker-volume.md
mesos-1.10.0/docs/isolators/filesystem-shared.md
mesos-1.10.0/docs/isolators/filesystems.md
mesos-1.10.0/docs/isolators/linux-capabilities.md
mesos-1.10.0/docs/isolators/linux-devices.md
mesos-1.10.0/docs/isolators/linux-nnp.md
mesos-1.10.0/docs/isolators/linux-seccomp.md
mesos-1.10.0/docs/isolators/namespaces-ipc.md
mesos-1.10.0/docs/isolators/namespaces-pid.md
mesos-1.10.0/docs/isolators/network-port-mapping.md
mesos-1.10.0/docs/isolators/network-ports.md
mesos-1.10.0/docs/isolators/posix-rlimits.md
mesos-1.10.0/docs/isolators/windows.md
mesos-1.10.0/docs/logging.md
mesos-1.10.0/docs/maintenance.md
mesos-1.10.0/docs/markdown-style-guide.md
mesos-1.10.0/docs/memory-profiling.md
mesos-1.10.0/docs/mesos-containerizer.md
mesos-1.10.0/docs/modules.md
mesos-1.10.0/docs/monitoring.md
mesos-1.10.0/docs/multiple-disk.md
mesos-1.10.0/docs/nested-container-and-task-group.md
mesos-1.10.0/docs/networking-for-mesos-managed-containers.md
mesos-1.10.0/docs/networking.md
mesos-1.10.0/docs/operational-guide.md
mesos-1.10.0/docs/operator-http-api.md
mesos-1.10.0/docs/oversubscription.md
mesos-1.10.0/docs/performance-profiling.md
mesos-1.10.0/docs/persistent-volume.md
mesos-1.10.0/docs/powered-by-mesos.md
mesos-1.10.0/docs/presentations.md
mesos-1.10.0/docs/quota.md
mesos-1.10.0/docs/reconciliation.md
mesos-1.10.0/docs/recordio.md
mesos-1.10.0/docs/release-guide.md
mesos-1.10.0/docs/reopening-reviews.md
mesos-1.10.0/docs/replicated-log-internals.md
mesos-1.10.0/docs/reporting-an-issue.md
mesos-1.10.0/docs/reservation.md
mesos-1.10.0/docs/resource-provider.md
mesos-1.10.0/docs/roadmap.md
mesos-1.10.0/docs/roles.md
mesos-1.10.0/docs/sandbox.md
mesos-1.10.0/docs/scheduler-http-api.md
mesos-1.10.0/docs/secrets.md
mesos-1.10.0/docs/shared-resources.md
mesos-1.10.0/docs/ssl.md
mesos-1.10.0/docs/task-state-reasons.md
mesos-1.10.0/docs/testing-patterns.md
mesos-1.10.0/docs/tools.md
mesos-1.10.0/docs/upgrades.md
mesos-1.10.0/docs/versioning.md
mesos-1.10.0/docs/weights.md
mesos-1.10.0/docs/windows.md
mesos-1.10.0/Doxyfile
mesos-1.10.0/.gitattributes
mesos-1.10.0/site/
mesos-1.10.0/site/build.sh
mesos-1.10.0/site/config.rb
mesos-1.10.0/site/data/
mesos-1.10.0/site/data/release_plan.yaml
mesos-1.10.0/site/data/releases.yml
mesos-1.10.0/site/doap.rdf
mesos-1.10.0/site/Dockerfile
mesos-1.10.0/site/entrypoint.sh
mesos-1.10.0/site/Gemfile
mesos-1.10.0/site/Gemfile.lock
mesos-1.10.0/site/.gitignore
mesos-1.10.0/site/mesos-website-dev.sh
mesos-1.10.0/site/Rakefile
mesos-1.10.0/site/README.md
mesos-1.10.0/site/source/
mesos-1.10.0/site/source/assets/
mesos-1.10.0/site/source/assets/css/
mesos-1.10.0/site/source/assets/css/bootstrap.css
mesos-1.10.0/site/source/assets/css/bootstrap.min.css
mesos-1.10.0/site/source/assets/css/bootstrap-responsive.min.css
mesos-1.10.0/site/source/assets/css/bootstrap-theme.css
mesos-1.10.0/site/source/assets/css/bootstrap-theme.min.css
mesos-1.10.0/site/source/assets/css/font-awesome-ie7.min.css
mesos-1.10.0/site/source/assets/css/font-awesome.min.css
mesos-1.10.0/site/source/assets/css/main.css
mesos-1.10.0/site/source/assets/fonts/
mesos-1.10.0/site/source/assets/fonts/glyphicons-halflings-regular.eot
mesos-1.10.0/site/source/assets/fonts/glyphicons-halflings-regular.svg
mesos-1.10.0/site/source/assets/fonts/glyphicons-halflings-regular.ttf
mesos-1.10.0/site/source/assets/fonts/glyphicons-halflings-regular.woff
mesos-1.10.0/site/source/assets/img/
mesos-1.10.0/site/source/assets/img/airbnb_logo.png
mesos-1.10.0/site/source/assets/img/background_image.png
mesos-1.10.0/site/source/assets/img/blog/
mesos-1.10.0/site/source/assets/img/blog/1.7-performance-improvements-allocation-cycle.png
mesos-1.10.0/site/source/assets/img/blog/1.7-performance-improvements-container-launch.png
mesos-1.10.0/site/source/assets/img/blog/1.7-performance-improvements-containers-endpoint-latency.png
mesos-1.10.0/site/source/assets/img/blog/1.7-performance-improvements-containers-endpoint-tasks.png
mesos-1.10.0/site/source/assets/img/blog/1.7-performance-improvements-parallel-state.png
mesos-1.10.0/site/source/assets/img/blog/1.7-performance-improvements-rapidjson.png
mesos-1.10.0/site/source/assets/img/blog/communitysurvey_2014_contributions.png
mesos-1.10.0/site/source/assets/img/blog/communitysurvey_2014_framework_aurora.png
mesos-1.10.0/site/source/assets/img/blog/communitysurvey_2014_framework_cassandra.png
mesos-1.10.0/site/source/assets/img/blog/communitysurvey_2014_framework_chronos.png
mesos-1.10.0/site/source/assets/img/blog/communitysurvey_2014_framework_custom.png
mesos-1.10.0/site/source/assets/img/blog/communitysurvey_2014_framework_hadoop.png
mesos-1.10.0/site/source/assets/img/blog/communitysurvey_2014_framework_jenkins.png
mesos-1.10.0/site/source/assets/img/blog/communitysurvey_2014_framework_jobserver.png
mesos-1.10.0/site/source/assets/img/blog/communitysurvey_2014_framework_marathon.png
mesos-1.10.0/site/source/assets/img/blog/communitysurvey_2014_framework_spark.png
mesos-1.10.0/site/source/assets/img/blog/communitysurvey_2014_framework_storm.png
mesos-1.10.0/site/source/assets/img/blog/communitysurvey_2014_howlong.png
mesos-1.10.0/site/source/assets/img/blog/communitysurvey_2014_howmanymachines.png
mesos-1.10.0/site/source/assets/img/blog/communitysurvey_2014_nps.png
mesos-1.10.0/site/source/assets/img/blog/communitysurvey_2014_poweredby.png
mesos-1.10.0/site/source/assets/img/blog/communitysurvey_2014_responses.png
mesos-1.10.0/site/source/assets/img/blog/communitysurvey_2014_wheredoyourun.png
mesos-1.10.0/site/source/assets/img/blog/mesos-1-7-0-performance.png
mesos-1.10.0/site/source/assets/img/glyphicons-halflings.png
mesos-1.10.0/site/source/assets/img/glyphicons-halflings-white.png
mesos-1.10.0/site/source/assets/img/mesoscon-2015-banner-small.png
mesos-1.10.0/site/source/assets/img/mesoscon-banner-small.png
mesos-1.10.0/site/source/assets/img/mesos_logo_dkblue.png
mesos-1.10.0/site/source/assets/img/mesos_logo_fb_preview.png
mesos-1.10.0/site/source/assets/img/mesos_logo.png
mesos-1.10.0/site/source/assets/img/twitter_logo.png
mesos-1.10.0/site/source/assets/img/ucberkeley_logo.png
mesos-1.10.0/site/source/assets/js/
mesos-1.10.0/site/source/assets/js/bootstrap-dropdown.js
mesos-1.10.0/site/source/assets/js/bootstrap.js
mesos-1.10.0/site/source/assets/js/bootstrap.min.js
mesos-1.10.0/site/source/assets/js/dev-community.js
mesos-1.10.0/site/source/assets/js/jquery-1.10.1.min.js
mesos-1.10.0/site/source/assets/papers/
mesos-1.10.0/site/source/assets/papers/hotcloud_nexus.pdf
mesos-1.10.0/site/source/assets/papers/hotcloud_spark.pdf
mesos-1.10.0/site/source/assets/papers/nsdi_drf.pdf
mesos-1.10.0/site/source/assets/papers/nsdi_mesos.pdf
mesos-1.10.0/site/source/blog/
mesos-1.10.0/site/source/blog/2013-10-23-slave-recovery-in-apache-mesos.md
mesos-1.10.0/site/source/blog/2013-11-12-mesos-0-14-2-released.md
mesos-1.10.0/site/source/blog/2013-12-16-niklas-nielsen-becomes-mesos-committer.md
mesos-1.10.0/site/source/blog/2014-01-09-framework-authentication-in-apache-mesos-0-15-0.md
mesos-1.10.0/site/source/blog/2014-02-11-mesos-0-16-0-released.md
mesos-1.10.0/site/source/blog/2014-03-13-mesos-0-17-0-released-featuring-autorecovery.md
mesos-1.10.0/site/source/blog/2014-03-28-mesos-community-update-1.md
mesos-1.10.0/site/source/blog/2014-04-10-mesos-0-18-0-released.md
mesos-1.10.0/site/source/blog/2014-05-29-mesos-0-18-1-and-0-18-2-released.md
mesos-1.10.0/site/source/blog/2014-06-11-mesoscon-2014-program-announced.md
mesos-1.10.0/site/source/blog/2014-06-12-mesos-0-19-0-released.md
mesos-1.10.0/site/source/blog/2014-06-24-mesos-community-survey-2014-results.md
mesos-1.10.0/site/source/blog/2014-07-21-mesos-0-19-1-released.md
mesos-1.10.0/site/source/blog/2014-07-24-mesoscon-2014-hackathon-details-announced.md
mesos-1.10.0/site/source/blog/2014-09-03-mesos-0-20-0-released.md
mesos-1.10.0/site/source/blog/2014-09-23-mesos-0-20-1-released.md
mesos-1.10.0/site/source/blog/2014-11-17-mesos-0-21-0-released.md
mesos-1.10.0/site/source/blog/2015-01-14-mesoscon-2015-earlybird-registration-now-open.md
mesos-1.10.0/site/source/blog/2015-01-20-mesos-0-21-1-released.md
mesos-1.10.0/site/source/blog/2015-03-25-mesos-0-22-0-released.md
mesos-1.10.0/site/source/blog/2015-05-12-mesos-0-22-1-released.md
mesos-1.10.0/site/source/blog/2015-07-01-mesoscon-seattle-keynote-speakers-announced.md
mesos-1.10.0/site/source/blog/2015-07-13-mesoscon-seattle-preconference-and-social-activities.md
mesos-1.10.0/site/source/blog/2015-07-28-register-for-mesoscon-seattle-save.md
mesos-1.10.0/site/source/blog/2015-07-29-mesos-0-23-0-released.md
mesos-1.10.0/site/source/blog/2015-08-05-mesoscon-goes-europe.md
mesos-1.10.0/site/source/blog/2015-09-17-mesoscon-europe-2015-schedule-announced.md
mesos-1.10.0/site/source/blog/2015-09-21-mesos-0-24-0-released.md
mesos-1.10.0/site/source/blog/2015-09-24-mesos-0-24-1-and-more-released.md
mesos-1.10.0/site/source/blog/2015-09-30-announcing-mesoscon-eu-2015-hackathon.md
mesos-1.10.0/site/source/blog/2015-10-12-mesos-0-25-0-released.md
mesos-1.10.0/site/source/blog/2015-12-16-mesos-0-26-0-released.md
mesos-1.10.0/site/source/blog/2016-02-02-mesos-0-27-0-released.md
mesos-1.10.0/site/source/blog/2016-02-12-mesoscon-2016-cfp-is-now-open.md
mesos-1.10.0/site/source/blog/2016-02-22-mesos-0-27-1-released.md
mesos-1.10.0/site/source/blog/2016-03-07-mesos-0-27-2-released.md
mesos-1.10.0/site/source/blog/2016-03-17-mesos-0-28-0-released.md
mesos-1.10.0/site/source/blog/2016-04-12-mesos-0-26-1-and-more-released.md
mesos-1.10.0/site/source/blog/2016-06-13-mesos-0-28-2-released.md
mesos-1.10.0/site/source/blog/2016-06-19-mesos-0-27-3-released.md
mesos-1.10.0/site/source/blog/2016-07-21-dev-community-status.md
mesos-1.10.0/site/source/blog/2016-07-27-mesos-1-0-0-released.md
mesos-1.10.0/site/source/blog/2016-08-23-mesos-1-0-1-released.md
mesos-1.10.0/site/source/blog/2016-11-10-mesos-1-1-0-released.md
mesos-1.10.0/site/source/blog/2016-11-15-mesos-1-0-2-released.md
mesos-1.10.0/site/source/blog/2016-12-20-mesos-0-28-3-released.md
mesos-1.10.0/site/source/blog/2017-02-06-mesos-1-0-3-released.md
mesos-1.10.0/site/source/blog/2017-03-08-mesos-1-2-0-released.md
mesos-1.10.0/site/source/blog/2017-03-14-mesos-1-1-1-released.md
mesos-1.10.0/site/source/blog/2017-05-03-mesos-1-0-4-released.md
mesos-1.10.0/site/source/blog/2017-06-07-mesos-1-3-0-released.md
mesos-1.10.0/site/source/blog/2017-06-12-mesos-1-2-1-released.md
mesos-1.10.0/site/source/blog/2017-08-11-mesos-1-2-2-released.md
mesos-1.10.0/site/source/blog/2017-08-15-mesos-1-3-1-released.md
mesos-1.10.0/site/source/blog/2017-08-31-mesos-1-1-3-released.md
mesos-1.10.0/site/source/blog/2017-09-18-mesos-1-4-0-released.md
mesos-1.10.0/site/source/blog/2017-11-16-mesos-1-4-1-released.md
mesos-1.10.0/site/source/blog/2017-12-01-mesos-1-2-3-released.md
mesos-1.10.0/site/source/blog/2017-12-07-performance-working-group-progress-report.md
mesos-1.10.0/site/source/blog/2017-12-12-storage-developments-in-apache-mesos.md
mesos-1.10.0/site/source/blog/2018-02-08-mesos-1-5-0-released.md
mesos-1.10.0/site/source/blog/2018-05-17-mesos-1-6-0-released.md
mesos-1.10.0/site/source/blog/2018-05-31-mesos-1-5-1-released.md
mesos-1.10.0/site/source/blog/2018-07-25-mesos-1-6-1-released.md
mesos-1.10.0/site/source/blog/2018-07-30-mesoscon-2018-cfp-is-now-open.md
mesos-1.10.0/site/source/blog/2018-08-20-mesos-1.4.2-released.md
mesos-1.10.0/site/source/blog/2018-09-05-mesoscon-2018-cfp-is-now-closed.md
mesos-1.10.0/site/source/blog/2018-09-24-mesos-1-7-0-released.md
mesos-1.10.0/site/source/blog/2018-10-08-mesos-1-7-0-performance-improvements.md
mesos-1.10.0/site/source/blog/2018-11-19-mesos-mini.md
mesos-1.10.0/site/source/blog/2019-01-24-mesos-1-5-2-released.md
mesos-1.10.0/site/source/blog/2019-01-28-mesos-1-7-1-released.md
mesos-1.10.0/site/source/blog/2019-02-26-mesos-1-4-3-released.md
mesos-1.10.0/site/source/blog/2019-03-19-mesos-1-5-3-released.md
mesos-1.10.0/site/source/blog/2019-05-02-mesos-1-8-0-released.md
mesos-1.10.0/site/source/blog/2019-07-29-mesos-1-8-1-released.md
mesos-1.10.0/site/source/blog/feed.xml.erb
mesos-1.10.0/site/source/blog.html.erb
mesos-1.10.0/site/source/community/
mesos-1.10.0/site/source/community.html.md
mesos-1.10.0/site/source/community/user-groups.html.md
mesos-1.10.0/site/source/downloads.html.erb
mesos-1.10.0/site/source/getting-started.html.md
mesos-1.10.0/site/source/.htaccess
mesos-1.10.0/site/source/index.html.erb
mesos-1.10.0/site/source/layouts/
mesos-1.10.0/site/source/layouts/basic.erb
mesos-1.10.0/site/source/layouts/community_section.erb
mesos-1.10.0/site/source/layouts/dev-community.erb
mesos-1.10.0/site/source/layouts/documentation.erb
mesos-1.10.0/site/source/layouts/getting_started_section.erb
mesos-1.10.0/site/source/layouts/layout.erb
mesos-1.10.0/site/source/layouts/post.erb
mesos-1.10.0/site/source/release-plan.html.erb
mesos-1.10.0/site/source/sitemap.xml.erb
mesos-1.10.0/src/checks/CMakeLists.txt
mesos-1.10.0/src/cli/CMakeLists.txt
mesos-1.10.0/src/cmake/
mesos-1.10.0/src/CMakeLists.txt
mesos-1.10.0/src/cmake/MesosProtobuf.cmake
mesos-1.10.0/src/common/build_config.hpp.in
mesos-1.10.0/src/examples/CMakeLists.txt
mesos-1.10.0/src/examples/python/Makefile.in
mesos-1.10.0/src/java/CMakeLists.txt
mesos-1.10.0/src/java/MESOS-MAVEN-README
mesos-1.10.0/src/launcher/CMakeLists.txt
mesos-1.10.0/src/local/CMakeLists.txt
mesos-1.10.0/src/log/CMakeLists.txt
mesos-1.10.0/src/main.dox
mesos-1.10.0/src/master/CMakeLists.txt
mesos-1.10.0/src/python/cli_new/
mesos-1.10.0/src/python/cli_new/activate
mesos-1.10.0/src/python/cli_new/bin/
mesos-1.10.0/src/python/cli_new/bin/main.py
mesos-1.10.0/src/python/cli_new/bin/mesos
mesos-1.10.0/src/python/cli_new/bin/mesos-cli-tests
mesos-1.10.0/src/python/cli_new/bin/settings.py
mesos-1.10.0/src/python/cli_new/bootstrap
mesos-1.10.0/src/python/cli_new/CMakeLists.txt
mesos-1.10.0/src/python/cli_new/deactivate
mesos-1.10.0/src/python/cli_new/lib/
mesos-1.10.0/src/python/cli_new/lib/cli/
mesos-1.10.0/src/python/cli_new/lib/cli/config.py
mesos-1.10.0/src/python/cli_new/lib/cli/constants.py
mesos-1.10.0/src/python/cli_new/lib/cli/docopt.py
mesos-1.10.0/src/python/cli_new/lib/cli/exceptions.py
mesos-1.10.0/src/python/cli_new/lib/cli/http.py
mesos-1.10.0/src/python/cli_new/lib/cli/__init__.py
mesos-1.10.0/src/python/cli_new/lib/cli/mesos.py
mesos-1.10.0/src/python/cli_new/lib/cli/plugins/
mesos-1.10.0/src/python/cli_new/lib/cli/plugins/agent/
mesos-1.10.0/src/python/cli_new/lib/cli/plugins/agent/__init__.py
mesos-1.10.0/src/python/cli_new/lib/cli/plugins/agent/main.py
mesos-1.10.0/src/python/cli_new/lib/cli/plugins/base.py
mesos-1.10.0/src/python/cli_new/lib/cli/plugins/config/
mesos-1.10.0/src/python/cli_new/lib/cli/plugins/config/__init__.py
mesos-1.10.0/src/python/cli_new/lib/cli/plugins/config/main.py
mesos-1.10.0/src/python/cli_new/lib/cli/plugins/__init__.py
mesos-1.10.0/src/python/cli_new/lib/cli/plugins/task/
mesos-1.10.0/src/python/cli_new/lib/cli/plugins/task/__init__.py
mesos-1.10.0/src/python/cli_new/lib/cli/plugins/task/main.py
mesos-1.10.0/src/python/cli_new/lib/cli/tests/
mesos-1.10.0/src/python/cli_new/lib/cli/tests/agent.py
mesos-1.10.0/src/python/cli_new/lib/cli/tests/base.py
mesos-1.10.0/src/python/cli_new/lib/cli/tests/constants.py
mesos-1.10.0/src/python/cli_new/lib/cli/tests/data/
mesos-1.10.0/src/python/cli_new/lib/cli/tests/data/lorem-ipsum.txt
mesos-1.10.0/src/python/cli_new/lib/cli/tests/__init__.py
mesos-1.10.0/src/python/cli_new/lib/cli/tests/task.py
mesos-1.10.0/src/python/cli_new/lib/cli/tests/tests.py
mesos-1.10.0/src/python/cli_new/lib/cli/util.py
mesos-1.10.0/src/python/cli_new/mesos.bash_completion
mesos-1.10.0/src/python/cli_new/pip-requirements.txt
mesos-1.10.0/src/python/cli_new/README.md
mesos-1.10.0/src/python/cli_new/tests/
mesos-1.10.0/src/python/cli_new/tests/CMakeLists.txt
mesos-1.10.0/src/python/cli_new/tests/default_config.toml
mesos-1.10.0/src/python/cli_new/tests/__init__.py
mesos-1.10.0/src/python/cli_new/tests/main.py
mesos-1.10.0/src/python/cli_new/tox.ini
mesos-1.10.0/src/python/executor/CMakeLists.txt
mesos-1.10.0/src/python/.gitignore
mesos-1.10.0/src/python/lib/
mesos-1.10.0/src/python/lib/mesos/
mesos-1.10.0/src/python/lib/mesos/exceptions.py
mesos-1.10.0/src/python/lib/mesos/http.py
mesos-1.10.0/src/python/lib/mesos/__init__.py
mesos-1.10.0/src/python/lib/mesos/recordio.py
mesos-1.10.0/src/python/lib/requirements.in
mesos-1.10.0/src/python/lib/setup.py
mesos-1.10.0/src/python/lib/tests/
mesos-1.10.0/src/python/lib/tests/conftest.py
mesos-1.10.0/src/python/lib/tests/__init__.py
mesos-1.10.0/src/python/lib/tests/test_exceptions.py
mesos-1.10.0/src/python/lib/tests/test_http.py
mesos-1.10.0/src/python/lib/tests/test_mesos.py
mesos-1.10.0/src/python/lib/tests/test_recordio.py
mesos-1.10.0/src/python/lib/tox.ini
mesos-1.10.0/src/python/protocol/
mesos-1.10.0/src/python/protocol/setup.py.in
mesos-1.10.0/src/python/protocol/src/
mesos-1.10.0/src/python/protocol/src/mesos/
mesos-1.10.0/src/python/protocol/src/mesos/__init__.py
mesos-1.10.0/src/python/protocol/src/mesos/protocol/
mesos-1.10.0/src/python/protocol/src/mesos/protocol/__init__.py
mesos-1.10.0/src/python/scheduler/CMakeLists.txt
mesos-1.10.0/src/resource_provider/storage/CMakeLists.txt
mesos-1.10.0/src/slave/CMakeLists.txt
mesos-1.10.0/src/slave/containerizer/mesos/CMakeLists.txt
mesos-1.10.0/src/slave/containerizer/mesos/isolators/filesystem/windows.cpp
mesos-1.10.0/src/slave/containerizer/mesos/isolators/windows/cpu.cpp
mesos-1.10.0/src/slave/containerizer/mesos/isolators/windows/mem.cpp
mesos-1.10.0/src/slave/container_loggers/CMakeLists.txt
mesos-1.10.0/src/slave/qos_controllers/CMakeLists.txt
mesos-1.10.0/src/slave/resource_estimators/CMakeLists.txt
mesos-1.10.0/src/tests/CMakeLists.txt
mesos-1.10.0/src/usage/CMakeLists.txt
mesos-1.10.0/support/apply-reviews.py
mesos-1.10.0/support/build-virtualenv
mesos-1.10.0/support/check-cmake-missing-files.sh
mesos-1.10.0/support/clang-format
mesos-1.10.0/support/clang-tidy
mesos-1.10.0/support/common.py
mesos-1.10.0/support/coverage.sh
mesos-1.10.0/support/cpplint.py
mesos-1.10.0/support/docker-build.sh
mesos-1.10.0/support/.eslintrc.js
mesos-1.10.0/support/generate-endpoint-help.py
mesos-1.10.0/support/get-review-ids.py
mesos-1.10.0/support/.gitignore
mesos-1.10.0/support/gitignore
mesos-1.10.0/support/hooks/
mesos-1.10.0/support/hooks/commit-msg
mesos-1.10.0/support/hooks/post-rewrite
mesos-1.10.0/support/hooks/pre-commit
mesos-1.10.0/support/jenkins/
mesos-1.10.0/support/jenkins/buildbot.sh
mesos-1.10.0/support/jenkins/cat.py
mesos-1.10.0/support/jenkins/docker-centos.sh
mesos-1.10.0/support/jenkins/Jenkinsfile-docker-centos
mesos-1.10.0/support/jenkins/Jenkinsfile-mini
mesos-1.10.0/support/jenkins/Jenkinsfile-packaging-centos
mesos-1.10.0/support/jenkins/mini.sh
mesos-1.10.0/support/jenkins/README.md
mesos-1.10.0/support/jenkins/reviewbot.sh
mesos-1.10.0/support/jenkins/tidybot.sh
mesos-1.10.0/support/jenkins/websitebot.sh
mesos-1.10.0/support/jenkins/windows-buildbot.bat
mesos-1.10.0/support/jsonurl.py
mesos-1.10.0/support/llvm/
mesos-1.10.0/support/llvm/install.sh
mesos-1.10.0/support/llvm/README.md
mesos-1.10.0/support/mesos-build/
mesos-1.10.0/support/mesos-build/centos-7.dockerfile
mesos-1.10.0/support/mesos-build/enable-devtoolset-4.sh
mesos-1.10.0/support/mesos-build/entrypoint.sh
mesos-1.10.0/support/mesos-build.sh
mesos-1.10.0/support/mesos-build/ubuntu-16.04-arm.dockerfile
mesos-1.10.0/support/mesos-build/ubuntu-16.04.dockerfile
mesos-1.10.0/support/mesos-mini/
mesos-1.10.0/support/mesos-mini/build.sh
mesos-1.10.0/support/mesos-mini/docker_daemon.json
mesos-1.10.0/support/mesos-mini/docker_env.sh
mesos-1.10.0/support/mesos-mini/Dockerfile
mesos-1.10.0/support/mesos-mini/docker.service
mesos-1.10.0/support/mesos-mini/entrypoint.sh
mesos-1.10.0/support/mesos-mini/marathon.service
mesos-1.10.0/support/mesos-mini/marathon.sh
mesos-1.10.0/support/mesos-mini/mesos/
mesos-1.10.0/support/mesos-mini/mesos/agent_environment
mesos-1.10.0/support/mesos-mini/mesos/master_environment
mesos-1.10.0/support/mesos-mini/mesos/modules/
mesos-1.10.0/support/mesos-mini/mesos/modules/uri_disk_profile.json
mesos-1.10.0/support/mesos-mini/mesos/ucr-default-bridge.json
mesos-1.10.0/support/mesos-reviewbot.ps1
mesos-1.10.0/support/mesos-split.py
mesos-1.10.0/support/mesos-style.py
mesos-1.10.0/support/mesos-tidy/
mesos-1.10.0/support/mesos-tidy/Dockerfile
mesos-1.10.0/support/mesos-tidy/entrypoint.sh
mesos-1.10.0/support/mesos-tidy/README.md
mesos-1.10.0/support/mesos-tidy.sh
mesos-1.10.0/support/mesos-website/
mesos-1.10.0/support/mesos-website/build.sh
mesos-1.10.0/support/mesos-website/Dockerfile
mesos-1.10.0/support/mesos-website/entrypoint.sh
mesos-1.10.0/support/mesos-website.sh
mesos-1.10.0/support/packaging/
mesos-1.10.0/support/packaging/bintray.sh
mesos-1.10.0/support/packaging/centos/
mesos-1.10.0/support/packaging/centos/build-docker-centos.sh
mesos-1.10.0/support/packaging/centos/build-docker-rpmbuild.sh
mesos-1.10.0/support/packaging/centos/build-rpm-docker.sh
mesos-1.10.0/support/packaging/centos/build_rpm.sh
mesos-1.10.0/support/packaging/centos/centos6.dockerfile
mesos-1.10.0/support/packaging/centos/centos7.dockerfile
mesos-1.10.0/support/packaging/centos/mesos.spec
mesos-1.10.0/support/packaging/centos/user-init.sh
mesos-1.10.0/support/packaging/common/
mesos-1.10.0/support/packaging/common/mesos
mesos-1.10.0/support/packaging/common/mesos-init-wrapper
mesos-1.10.0/support/packaging/common/mesos-master
mesos-1.10.0/support/packaging/common/mesos-master.service
mesos-1.10.0/support/packaging/common/mesos-master.upstart
mesos-1.10.0/support/packaging/common/mesos-slave
mesos-1.10.0/support/packaging/common/mesos-slave.service
mesos-1.10.0/support/packaging/common/mesos-slave.upstart
mesos-1.10.0/support/packaging/Jenkinsfile
mesos-1.10.0/support/pip-requirements.txt
mesos-1.10.0/support/post-build-result.py
mesos-1.10.0/support/post-reviews.py
mesos-1.10.0/support/push-commits.py
mesos-1.10.0/support/pylint.config
mesos-1.10.0/support/README.md
mesos-1.10.0/support/release.sh
mesos-1.10.0/support/reviewboardrc
mesos-1.10.0/support/snapshot.sh
mesos-1.10.0/support/test-upgrade.py
mesos-1.10.0/support/timed-tests.sh
mesos-1.10.0/support/verify-reviews.py
mesos-1.10.0/support/vote.sh
mesos-1.10.0/support/windows-build.bat
- Benjamin Bannier
On Sept. 3, 2019, 3:52 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71240/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2019, 3:52 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a `dist` target to the cmake build, analogous to the
> target provided by the autotools build.
>
> While cmake already provides a `package_source` target to create a
> source archive it does not take care of only including relevant files,
> but instead adds all files to the archive, e.g., including build or
> backup files which should not be part of a release. For that reason this
> patch introduces a script which performs a temporary `git clone` from
> the checked out git repository and creates the archive from that clean
> tree.
>
> This patch also removes a hardcoded list of ignored files which was
> by design not exhaustive.
>
>
> Diffs
> -----
>
> CMakeLists.txt dc50dd457585c14a456ca710da4a16a0d45ef17a
> cmake/dist.sh PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/71240/diff/2/
>
>
> Testing
> -------
>
> `ninja dist` produces a tarball, no artifacts left around but tarball.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71240: Added a `dist` target to the cmake build.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71240/#review217579
-----------------------------------------------------------
cmake/dist.sh
Lines 30 (patched)
<https://reviews.apache.org/r/71240/#comment304854>
Will fail with my setup as my repo-dir is called different than "mesos".
- Till Toenshoff
On Sept. 3, 2019, 1:52 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71240/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2019, 1:52 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a `dist` target to the cmake build, analogous to the
> target provided by the autotools build.
>
> While cmake already provides a `package_source` target to create a
> source archive it does not take care of only including relevant files,
> but instead adds all files to the archive, e.g., including build or
> backup files which should not be part of a release. For that reason this
> patch introduces a script which performs a temporary `git clone` from
> the checked out git repository and creates the archive from that clean
> tree.
>
> This patch also removes a hardcoded list of ignored files which was
> by design not exhaustive.
>
>
> Diffs
> -----
>
> CMakeLists.txt dc50dd457585c14a456ca710da4a16a0d45ef17a
> cmake/dist.sh PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/71240/diff/2/
>
>
> Testing
> -------
>
> `ninja dist` produces a tarball, no artifacts left around but tarball.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71240: Added a `dist` target to the cmake build.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71240/
-----------------------------------------------------------
(Updated Sept. 6, 2019, 12:13 p.m.)
Review request for mesos, Benjamin Mahler and Till Toenshoff.
Repository: mesos
Description
-------
This patch adds a `dist` target to the cmake build, analogous to the
target provided by the autotools build.
While cmake already provides a `package_source` target to create a
source archive it does not take care of only including relevant files,
but instead adds all files to the archive, e.g., including build or
backup files which should not be part of a release. For that reason this
patch introduces a script which performs a temporary `git clone` from
the checked out git repository and creates the archive from that clean
tree.
This patch also removes a hardcoded list of ignored files which was
by design not exhaustive.
Diffs (updated)
-----
CMakeLists.txt dc50dd457585c14a456ca710da4a16a0d45ef17a
cmake/dist.sh PRE-CREATION
Diff: https://reviews.apache.org/r/71240/diff/3/
Changes: https://reviews.apache.org/r/71240/diff/2-3/
Testing
-------
`ninja dist` produces a tarball, no artifacts left around but tarball.
Thanks,
Benjamin Bannier
Re: Review Request 71240: Added a `dist` target to the cmake build.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71240/
-----------------------------------------------------------
(Updated Sept. 3, 2019, 3:52 p.m.)
Review request for mesos, Benjamin Mahler and Till Toenshoff.
Changes
-------
Address issues raised by Benno
Repository: mesos
Description
-------
This patch adds a `dist` target to the cmake build, analogous to the
target provided by the autotools build.
While cmake already provides a `package_source` target to create a
source archive it does not take care of only including relevant files,
but instead adds all files to the archive, e.g., including build or
backup files which should not be part of a release. For that reason this
patch introduces a script which performs a temporary `git clone` from
the checked out git repository and creates the archive from that clean
tree.
This patch also removes a hardcoded list of ignored files which was
by design not exhaustive.
Diffs (updated)
-----
CMakeLists.txt dc50dd457585c14a456ca710da4a16a0d45ef17a
cmake/dist.sh PRE-CREATION
Diff: https://reviews.apache.org/r/71240/diff/2/
Changes: https://reviews.apache.org/r/71240/diff/1-2/
Testing
-------
`ninja dist` produces a tarball, no artifacts left around but tarball.
Thanks,
Benjamin Bannier
Re: Review Request 71240: Added a `dist` target to the cmake build.
Posted by Benjamin Bannier <bb...@apache.org>.
> On Sept. 3, 2019, 3:08 p.m., Benno Evers wrote:
> > cmake/dist.sh
> > Lines 8 (patched)
> > <https://reviews.apache.org/r/71240/diff/1/?file=2159993#file2159993line8>
> >
> > Why this restriction if we're going to create the tarball from a clean checkout anyways?
The purpose of this is to prevent situations where somebody creates a dist tarball from a dirty tree only to not have the changes reflected in the created tarball. This would be confusing and error-prone behavior.
> On Sept. 3, 2019, 3:08 p.m., Benno Evers wrote:
> > cmake/dist.sh
> > Lines 19 (patched)
> > <https://reviews.apache.org/r/71240/diff/1/?file=2159993#file2159993line19>
> >
> > I'm not sure if this is written down anywhere, but in general it's a good shell-script best practice to use `SCREAMING_CASE` for variables that can be overriden from outside and `lower_case` for variables that are internal to the script.
That sounds reasonable, but would not at all be in line with our current convention.
Dropping this for now.
> On Sept. 3, 2019, 3:08 p.m., Benno Evers wrote:
> > cmake/dist.sh
> > Lines 21 (patched)
> > <https://reviews.apache.org/r/71240/diff/1/?file=2159993#file2159993line21>
> >
> > Can we find a more speaking name than `D` for this? Also, since this is used as a temporary directory it might make sense to use `mktemp -d` rather than hardcoding the directory name.
Great suggestion on the temp dir (I had modelled this after autotools' `make distcheck` always using a fixed output directory in the build directory; now that I think about that I am not sure that was ever useful to me and not just an opportunity for name collisions in a dirty tree). Went with `WORKDIR` as var name.
> On Sept. 3, 2019, 3:08 p.m., Benno Evers wrote:
> > cmake/dist.sh
> > Lines 29 (patched)
> > <https://reviews.apache.org/r/71240/diff/1/?file=2159993#file2159993line29>
> >
> > Can you explain why in-tree builds are not supported, i.e. why do we need to create a separate build directory here?
TBH, I cannot, but this is a general feature of our cmake setup (I suspect it has to do with aspects like generated files).
Dropping.
> On Sept. 3, 2019, 3:08 p.m., Benno Evers wrote:
> > cmake/dist.sh
> > Lines 33 (patched)
> > <https://reviews.apache.org/r/71240/diff/1/?file=2159993#file2159993line33>
> >
> > I assume `nproc` is some magic cmake variable that is set automatically?
`nproc` is part of coreutils which we also assume elsewhere.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71240/#review217539
-----------------------------------------------------------
On Sept. 3, 2019, 3:52 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71240/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2019, 3:52 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a `dist` target to the cmake build, analogous to the
> target provided by the autotools build.
>
> While cmake already provides a `package_source` target to create a
> source archive it does not take care of only including relevant files,
> but instead adds all files to the archive, e.g., including build or
> backup files which should not be part of a release. For that reason this
> patch introduces a script which performs a temporary `git clone` from
> the checked out git repository and creates the archive from that clean
> tree.
>
> This patch also removes a hardcoded list of ignored files which was
> by design not exhaustive.
>
>
> Diffs
> -----
>
> CMakeLists.txt dc50dd457585c14a456ca710da4a16a0d45ef17a
> cmake/dist.sh PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/71240/diff/2/
>
>
> Testing
> -------
>
> `ninja dist` produces a tarball, no artifacts left around but tarball.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71240: Added a `dist` target to the cmake build.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71240/#review217539
-----------------------------------------------------------
cmake/dist.sh
Lines 8 (patched)
<https://reviews.apache.org/r/71240/#comment304789>
Why this restriction if we're going to create the tarball from a clean checkout anyways?
cmake/dist.sh
Lines 19 (patched)
<https://reviews.apache.org/r/71240/#comment304793>
I'm not sure if this is written down anywhere, but in general it's a good shell-script best practice to use `SCREAMING_CASE` for variables that can be overriden from outside and `lower_case` for variables that are internal to the script.
cmake/dist.sh
Lines 21 (patched)
<https://reviews.apache.org/r/71240/#comment304790>
Can we find a more speaking name than `D` for this? Also, since this is used as a temporary directory it might make sense to use `mktemp -d` rather than hardcoding the directory name.
cmake/dist.sh
Lines 29 (patched)
<https://reviews.apache.org/r/71240/#comment304797>
Can you explain why in-tree builds are not supported, i.e. why do we need to create a separate build directory here?
cmake/dist.sh
Lines 33 (patched)
<https://reviews.apache.org/r/71240/#comment304791>
I assume `nproc` is some magic cmake variable that is set automatically?
- Benno Evers
On Aug. 6, 2019, 7:28 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71240/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2019, 7:28 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a `dist` target to the cmake build, analogous to the
> target provided by the autotools build.
>
> While cmake already provides a `package_source` target to create a
> source archive it does not take care of only including relevant files,
> but instead adds all files to the archive, e.g., including build or
> backup files which should not be part of a release. For that reason this
> patch introduces a script which performs a temporary `git clone` from
> the checked out git repository and creates the archive from that clean
> tree.
>
> This patch also removes a hardcoded list of ignored files which was
> by design not exhaustive.
>
>
> Diffs
> -----
>
> CMakeLists.txt 65bfbac0e2b6aec26a6d98ff96615661210ceac2
> cmake/dist.sh PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/71240/diff/1/
>
>
> Testing
> -------
>
> `ninja dist` produces a tarball, no artifacts left around but tarball.
>
>
> Thanks,
>
> Benjamin Bannier
>
>