You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Angelo van der Sijpt (JIRA)" <ji...@apache.org> on 2008/01/24 20:20:34 UTC
[jira] Created: (FELIX-471) FilterImpl.toString() does not add
escape characters
FilterImpl.toString() does not add escape characters
----------------------------------------------------
Key: FELIX-471
URL: https://issues.apache.org/jira/browse/FELIX-471
Project: Felix
Issue Type: Bug
Components: Framework
Reporter: Angelo van der Sijpt
FilterImpl.toString() is not a complete representation of the filter string that was used to create it: four characters ( '(', ')', '/' and '*' ) should be preceded by a '\' if they are to be used in a value.
For example,
new FilterImpl("(b=\(*)").toString();
should return '(b=\(*)', but it returns '(b=(*)'. So, it can happen that a correct Filter f, when used in
new FilterImpl(f.toString());
causes an InvalidSyntaxException.
(see http://www2.osgi.org/javadoc/r4/org/osgi/framework/Filter.html#toString() for what toString() should do).
See the attached patch for a proposed solution.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (FELIX-471) FilterImpl.toString() does not add
escape characters
Posted by "Karl Pauls (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karl Pauls reassigned FELIX-471:
--------------------------------
Assignee: Karl Pauls
> FilterImpl.toString() does not add escape characters
> ----------------------------------------------------
>
> Key: FELIX-471
> URL: https://issues.apache.org/jira/browse/FELIX-471
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Reporter: Angelo van der Sijpt
> Assignee: Karl Pauls
> Attachments: FELIX-471.patch
>
>
> FilterImpl.toString() is not a complete representation of the filter string that was used to create it: four characters ( '(', ')', '/' and '*' ) should be preceded by a '\' if they are to be used in a value.
> For example,
> new FilterImpl("(b=\(*)").toString();
> should return '(b=\(*)', but it returns '(b=(*)'. So, it can happen that a correct Filter f, when used in
> new FilterImpl(f.toString());
> causes an InvalidSyntaxException.
> (see http://www2.osgi.org/javadoc/r4/org/osgi/framework/Filter.html#toString() for what toString() should do).
> See the attached patch for a proposed solution.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-471) FilterImpl.toString() does not add
escape characters
Posted by "Angelo van der Sijpt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Angelo van der Sijpt updated FELIX-471:
---------------------------------------
Attachment: FELIX-471.patch
> FilterImpl.toString() does not add escape characters
> ----------------------------------------------------
>
> Key: FELIX-471
> URL: https://issues.apache.org/jira/browse/FELIX-471
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Reporter: Angelo van der Sijpt
> Attachments: FELIX-471.patch
>
>
> FilterImpl.toString() is not a complete representation of the filter string that was used to create it: four characters ( '(', ')', '/' and '*' ) should be preceded by a '\' if they are to be used in a value.
> For example,
> new FilterImpl("(b=\(*)").toString();
> should return '(b=\(*)', but it returns '(b=(*)'. So, it can happen that a correct Filter f, when used in
> new FilterImpl(f.toString());
> causes an InvalidSyntaxException.
> (see http://www2.osgi.org/javadoc/r4/org/osgi/framework/Filter.html#toString() for what toString() should do).
> See the attached patch for a proposed solution.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (FELIX-471) FilterImpl.toString() does not add
escape characters
Posted by "Karl Pauls (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karl Pauls resolved FELIX-471.
------------------------------
Resolution: Fixed
I commited the patch after applying our code style. Please close this issue if everything works for you.
> FilterImpl.toString() does not add escape characters
> ----------------------------------------------------
>
> Key: FELIX-471
> URL: https://issues.apache.org/jira/browse/FELIX-471
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Reporter: Angelo van der Sijpt
> Assignee: Karl Pauls
> Attachments: FELIX-471.patch
>
>
> FilterImpl.toString() is not a complete representation of the filter string that was used to create it: four characters ( '(', ')', '/' and '*' ) should be preceded by a '\' if they are to be used in a value.
> For example,
> new FilterImpl("(b=\(*)").toString();
> should return '(b=\(*)', but it returns '(b=(*)'. So, it can happen that a correct Filter f, when used in
> new FilterImpl(f.toString());
> causes an InvalidSyntaxException.
> (see http://www2.osgi.org/javadoc/r4/org/osgi/framework/Filter.html#toString() for what toString() should do).
> See the attached patch for a proposed solution.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (FELIX-471) FilterImpl.toString() does not add
escape characters
Posted by "Angelo van der Sijpt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Angelo van der Sijpt closed FELIX-471.
--------------------------------------
> FilterImpl.toString() does not add escape characters
> ----------------------------------------------------
>
> Key: FELIX-471
> URL: https://issues.apache.org/jira/browse/FELIX-471
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Reporter: Angelo van der Sijpt
> Assignee: Karl Pauls
> Attachments: FELIX-471.patch
>
>
> FilterImpl.toString() is not a complete representation of the filter string that was used to create it: four characters ( '(', ')', '/' and '*' ) should be preceded by a '\' if they are to be used in a value.
> For example,
> new FilterImpl("(b=\(*)").toString();
> should return '(b=\(*)', but it returns '(b=(*)'. So, it can happen that a correct Filter f, when used in
> new FilterImpl(f.toString());
> causes an InvalidSyntaxException.
> (see http://www2.osgi.org/javadoc/r4/org/osgi/framework/Filter.html#toString() for what toString() should do).
> See the attached patch for a proposed solution.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-471) FilterImpl.toString() does not add
escape characters
Posted by "Karl Pauls (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12562177#action_12562177 ]
Karl Pauls commented on FELIX-471:
----------------------------------
Good catch. This will make it into 1.0.2. Thanks.
> FilterImpl.toString() does not add escape characters
> ----------------------------------------------------
>
> Key: FELIX-471
> URL: https://issues.apache.org/jira/browse/FELIX-471
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Reporter: Angelo van der Sijpt
> Assignee: Karl Pauls
> Attachments: FELIX-471.patch
>
>
> FilterImpl.toString() is not a complete representation of the filter string that was used to create it: four characters ( '(', ')', '/' and '*' ) should be preceded by a '\' if they are to be used in a value.
> For example,
> new FilterImpl("(b=\(*)").toString();
> should return '(b=\(*)', but it returns '(b=(*)'. So, it can happen that a correct Filter f, when used in
> new FilterImpl(f.toString());
> causes an InvalidSyntaxException.
> (see http://www2.osgi.org/javadoc/r4/org/osgi/framework/Filter.html#toString() for what toString() should do).
> See the attached patch for a proposed solution.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-471) FilterImpl.toString() does not add
escape characters
Posted by "Angelo van der Sijpt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12562403#action_12562403 ]
Angelo van der Sijpt commented on FELIX-471:
--------------------------------------------
Works fine, thanks.
> FilterImpl.toString() does not add escape characters
> ----------------------------------------------------
>
> Key: FELIX-471
> URL: https://issues.apache.org/jira/browse/FELIX-471
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Reporter: Angelo van der Sijpt
> Assignee: Karl Pauls
> Attachments: FELIX-471.patch
>
>
> FilterImpl.toString() is not a complete representation of the filter string that was used to create it: four characters ( '(', ')', '/' and '*' ) should be preceded by a '\' if they are to be used in a value.
> For example,
> new FilterImpl("(b=\(*)").toString();
> should return '(b=\(*)', but it returns '(b=(*)'. So, it can happen that a correct Filter f, when used in
> new FilterImpl(f.toString());
> causes an InvalidSyntaxException.
> (see http://www2.osgi.org/javadoc/r4/org/osgi/framework/Filter.html#toString() for what toString() should do).
> See the attached patch for a proposed solution.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.