[GitHub] mrutkows commented on issue #367: Enable field 'function' of Action entity, mark 'location' as deprecated

[gi...@git.apache.org]

mrutkows commented on issue #367: Enable field 'function' of Action entity, mark 'location' as deprecated
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/367#issuecomment-323872933
 
 
   I have been seeing 2 issues; one is missing unit tests for the change:
   ok  	github.com/apache/incubator-openwhisk-wskdeploy/deployers	0.008s
   
   --- FAIL: TestParseManifestYAML_feed (0.00s)
   
   	Error Trace:	yamlparser_test.go:135
   
   	Error:      	Not equal: 
   
   	            	expected: "https://my.company.com/services/eventHub"
   
   	            	actual: ""
   
   	Messages:   	Get feed location failed.
   
   FAIL
   
   FAIL	github.com/apache/incubator-openwhisk-wskdeploy/parsers	0.009s
   
   ?   	github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/common	[no test files]
   
   ok  	github.com/apache/incubator-openwhisk-wskdeploy/utils	0.513s
   
   ?   	github.com/apache/incubator-openwhisk-wskdeploy/wski18n	[no test files]
   
   make: *** [test] Error 1
   
   The command "make build" exited with 2.
   
   ---
   The 2nd issue is flakiness in Travis build where wskdeploy binary is not found.  We NEED to use "set -e" for force Bash scripts to exit on first failure.  I am curious to see if the unit test issue is fixed if the 2nd error goes away.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services