You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Ashish Singh <as...@cloudera.com> on 2014/12/11 07:11:10 UTC
Re: Review Request 28108: KAFKA-1664: Kafka does not properly parse
multiple ZK nodes with non-root chroot
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28108/
-----------------------------------------------------------
(Updated Dec. 11, 2014, 6:11 a.m.)
Review request for kafka.
Changes
-------
Add unit tests for ZkPath.
Repository: kafka
Description
-------
KAFKA-1664: Kafka does not properly parse multiple ZK nodes with non-root chroot
Diffs (updated)
-----
core/src/main/scala/kafka/utils/ZkUtils.scala 56e3e88e0cc6d917b0ffd1254e173295c1c4aabd
core/src/test/scala/unit/kafka/zk/ZKPathTest.scala PRE-CREATION
Diff: https://reviews.apache.org/r/28108/diff/
Testing
-------
Tested with and without the fix.
Thanks,
Ashish Singh
Re: Review Request 28108: Patch for KAFKA-1664
Posted by Ashish Singh <as...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28108/
-----------------------------------------------------------
(Updated Feb. 24, 2015, 7:02 p.m.)
Review request for kafka.
Bugs: KAFKA-1664
https://issues.apache.org/jira/browse/KAFKA-1664
Repository: kafka
Description
-------
KAFKA-1664: Kafka does not properly parse multiple ZK nodes with non-root chroot
Diffs (updated)
-----
core/src/main/scala/kafka/utils/ZkUtils.scala 8a2fb2d9a42aeaaa5f61d504e123c5f707c83682
core/src/test/scala/unit/kafka/zk/ZKPathTest.scala PRE-CREATION
Diff: https://reviews.apache.org/r/28108/diff/
Testing
-------
Tested with and without the fix.
Thanks,
Ashish Singh
Re: Review Request 28108: Patch for KAFKA-1664
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28108/#review73825
-----------------------------------------------------------
Ship it!
Ship It!
- Neha Narkhede
On Jan. 29, 2015, 6:26 p.m., Ashish Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28108/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2015, 6:26 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1664
> https://issues.apache.org/jira/browse/KAFKA-1664
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1664: Kafka does not properly parse multiple ZK nodes with non-root chroot
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/utils/ZkUtils.scala c14bd455b6642f5e6eb254670bef9f57ae41d6cb
> core/src/test/scala/unit/kafka/zk/ZKPathTest.scala PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28108/diff/
>
>
> Testing
> -------
>
> Tested with and without the fix.
>
>
> Thanks,
>
> Ashish Singh
>
>
Re: Review Request 28108: Patch for KAFKA-1664
Posted by Ashish Singh <as...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28108/
-----------------------------------------------------------
(Updated Jan. 29, 2015, 6:26 p.m.)
Review request for kafka.
Summary (updated)
-----------------
Patch for KAFKA-1664
Bugs: KAFKA-1664
https://issues.apache.org/jira/browse/KAFKA-1664
Repository: kafka
Description
-------
KAFKA-1664: Kafka does not properly parse multiple ZK nodes with non-root chroot
Diffs (updated)
-----
core/src/main/scala/kafka/utils/ZkUtils.scala c14bd455b6642f5e6eb254670bef9f57ae41d6cb
core/src/test/scala/unit/kafka/zk/ZKPathTest.scala PRE-CREATION
Diff: https://reviews.apache.org/r/28108/diff/
Testing
-------
Tested with and without the fix.
Thanks,
Ashish Singh
Re: Review Request 28108: Patch for KAFKA-1664
Posted by Ashish Singh <as...@cloudera.com>.
> On Jan. 26, 2015, 1:54 a.m., Neha Narkhede wrote:
> > Sorry for the late review. Can check this in once you get a chance to address these review suggestions.
Thanks for the review. Addressed the concerns.
> On Jan. 26, 2015, 1:54 a.m., Neha Narkhede wrote:
> > core/src/test/scala/unit/kafka/zk/ZKPathTest.scala, line 63
> > <https://reviews.apache.org/r/28108/diff/3/?file=789148#file789148line63>
> >
> > typo: zkConnectWithInvaidRoot
Good catch!
- Ashish
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28108/#review69582
-----------------------------------------------------------
On Jan. 29, 2015, 6:26 p.m., Ashish Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28108/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2015, 6:26 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1664
> https://issues.apache.org/jira/browse/KAFKA-1664
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1664: Kafka does not properly parse multiple ZK nodes with non-root chroot
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/utils/ZkUtils.scala c14bd455b6642f5e6eb254670bef9f57ae41d6cb
> core/src/test/scala/unit/kafka/zk/ZKPathTest.scala PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28108/diff/
>
>
> Testing
> -------
>
> Tested with and without the fix.
>
>
> Thanks,
>
> Ashish Singh
>
>
Re: Review Request 28108: KAFKA-1664: Kafka does not properly parse
multiple ZK nodes with non-root chroot
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28108/#review69582
-----------------------------------------------------------
Sorry for the late review. Can check this in once you get a chance to address these review suggestions.
core/src/main/scala/kafka/utils/ZkUtils.scala
<https://reviews.apache.org/r/28108/#comment114289>
what is the purpose of this return statement? Seems inconsistent with the coding convention
core/src/test/scala/unit/kafka/zk/ZKPathTest.scala
<https://reviews.apache.org/r/28108/#comment114290>
typo: zkConnectWithInvaidRoot
- Neha Narkhede
On Dec. 11, 2014, 6:16 a.m., Ashish Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28108/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2014, 6:16 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1664
> https://issues.apache.org/jira/browse/KAFKA-1664
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1664: Kafka does not properly parse multiple ZK nodes with non-root chroot
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/utils/ZkUtils.scala 56e3e88e0cc6d917b0ffd1254e173295c1c4aabd
> core/src/test/scala/unit/kafka/zk/ZKPathTest.scala PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28108/diff/
>
>
> Testing
> -------
>
> Tested with and without the fix.
>
>
> Thanks,
>
> Ashish Singh
>
>
Re: Review Request 28108: KAFKA-1664: Kafka does not properly parse
multiple ZK nodes with non-root chroot
Posted by Ashish Singh <as...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28108/
-----------------------------------------------------------
(Updated Dec. 11, 2014, 6:16 a.m.)
Review request for kafka.
Changes
-------
Link JIRA.
Bugs: KAFKA-1664
https://issues.apache.org/jira/browse/KAFKA-1664
Repository: kafka
Description
-------
KAFKA-1664: Kafka does not properly parse multiple ZK nodes with non-root chroot
Diffs
-----
core/src/main/scala/kafka/utils/ZkUtils.scala 56e3e88e0cc6d917b0ffd1254e173295c1c4aabd
core/src/test/scala/unit/kafka/zk/ZKPathTest.scala PRE-CREATION
Diff: https://reviews.apache.org/r/28108/diff/
Testing
-------
Tested with and without the fix.
Thanks,
Ashish Singh