You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/02/20 22:07:31 UTC
Re: Review Request 18144: Updated resource model reporting to respect
multiple roles.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18144/
-----------------------------------------------------------
(Updated Feb. 20, 2014, 1:07 p.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Summary (updated)
-----------------
Updated resource model reporting to respect multiple roles.
Bugs: MESOS-692 and MESOS-990
https://issues.apache.org/jira/browse/MESOS-692
https://issues.apache.org/jira/browse/MESOS-990
Repository: mesos-git
Description
-------
See summary
Diffs (updated)
-----
src/Makefile.am e02d416e5cb8edf6c44ed05c5785a5084bf02abb
src/common/http.hpp PRE-CREATION
src/common/http.cpp PRE-CREATION
src/master/http.cpp c9412749baeb88e8fc270eeca8710f04da2ac076
src/slave/http.cpp 7c4cfba6676124926cfaa665df9fccf68c7dc187
Diff: https://reviews.apache.org/r/18144/diff/
Testing
-------
make check.
ran master/slave and checked http://localhost:5050/master/state.json by eye.
ran local/python test framework and watched webui main, framework, and slave pages.
Thanks,
Dominic Hamon
Re: Review Request 18144: Updated resource model reporting to respect
multiple roles.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Feb. 21, 2014, 12:02 a.m., Ben Mahler wrote:
> > src/common/http.hpp, lines 31-32
> > <https://reviews.apache.org/r/18144/diff/13/?file=499528#file499528line31>
> >
> > When are you planning to do this TODO Dominic?
> >
> > We should avoid making API changes that are short-term, in this case exposing "role_resources" temporarily seems like a bad idea. Why even expose "role_resources" at all in this patch?
> >
> > What about the following for this patch:
> > 1. Kill perRoleModel and "role_resources", since it's not being used and we plan to kill it anyway.
> > 2. Your fix for model(Resource&) can remain since it fixes MESOS-692 by summing resources.
> >
> > And a follow-up patch:
> > 1. Exposes roles in model(Resources&) by swapping it with your perRoleModel implementation.
> > 2. Updates the webui to handle the new format.
It seems like the webui fixes could be localized to just converting the new format to the old format and otherwise leaving the webui as is for now.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18144/#review35112
-----------------------------------------------------------
On Feb. 20, 2014, 11:04 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18144/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2014, 11:04 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-692 and MESOS-990
> https://issues.apache.org/jira/browse/MESOS-692
> https://issues.apache.org/jira/browse/MESOS-990
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> src/Makefile.am e02d416e5cb8edf6c44ed05c5785a5084bf02abb
> src/common/http.hpp PRE-CREATION
> src/common/http.cpp PRE-CREATION
> src/master/http.cpp c9412749baeb88e8fc270eeca8710f04da2ac076
> src/slave/http.cpp 7c4cfba6676124926cfaa665df9fccf68c7dc187
>
> Diff: https://reviews.apache.org/r/18144/diff/
>
>
> Testing
> -------
>
> make check.
>
> ran master/slave and checked http://localhost:5050/master/state.json by eye.
>
> ran local/python test framework and watched webui main, framework, and slave pages.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 18144: Updated resource model reporting to respect
multiple roles.
Posted by Dominic Hamon <dh...@twopensource.com>.
> On Feb. 20, 2014, 4:02 p.m., Ben Mahler wrote:
> > src/common/http.hpp, lines 31-32
> > <https://reviews.apache.org/r/18144/diff/13/?file=499528#file499528line31>
> >
> > When are you planning to do this TODO Dominic?
> >
> > We should avoid making API changes that are short-term, in this case exposing "role_resources" temporarily seems like a bad idea. Why even expose "role_resources" at all in this patch?
> >
> > What about the following for this patch:
> > 1. Kill perRoleModel and "role_resources", since it's not being used and we plan to kill it anyway.
> > 2. Your fix for model(Resource&) can remain since it fixes MESOS-692 by summing resources.
> >
> > And a follow-up patch:
> > 1. Exposes roles in model(Resources&) by swapping it with your perRoleModel implementation.
> > 2. Updates the webui to handle the new format.
>
> Benjamin Hindman wrote:
> It seems like the webui fixes could be localized to just converting the new format to the old format and otherwise leaving the webui as is for now.
I went down the route of transforming the new resource format to the old one, but it gets pretty hairy to catch all the places it happens.
I like Ben's suggestion of keeping this focused on fixing the sum problem (new patch incoming) and then updating the webui properly for per-role resources. This might include adding dropdowns for breakdowns, etc.
- Dominic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18144/#review35112
-----------------------------------------------------------
On Feb. 20, 2014, 3:04 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18144/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2014, 3:04 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-692 and MESOS-990
> https://issues.apache.org/jira/browse/MESOS-692
> https://issues.apache.org/jira/browse/MESOS-990
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> src/Makefile.am e02d416e5cb8edf6c44ed05c5785a5084bf02abb
> src/common/http.hpp PRE-CREATION
> src/common/http.cpp PRE-CREATION
> src/master/http.cpp c9412749baeb88e8fc270eeca8710f04da2ac076
> src/slave/http.cpp 7c4cfba6676124926cfaa665df9fccf68c7dc187
>
> Diff: https://reviews.apache.org/r/18144/diff/
>
>
> Testing
> -------
>
> make check.
>
> ran master/slave and checked http://localhost:5050/master/state.json by eye.
>
> ran local/python test framework and watched webui main, framework, and slave pages.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 18144: Updated resource model reporting to respect
multiple roles.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18144/#review35112
-----------------------------------------------------------
src/common/http.hpp
<https://reviews.apache.org/r/18144/#comment65517>
When are you planning to do this TODO Dominic?
We should avoid making API changes that are short-term, in this case exposing "role_resources" temporarily seems like a bad idea. Why even expose "role_resources" at all in this patch?
What about the following for this patch:
1. Kill perRoleModel and "role_resources", since it's not being used and we plan to kill it anyway.
2. Your fix for model(Resource&) can remain since it fixes MESOS-692 by summing resources.
And a follow-up patch:
1. Exposes roles in model(Resources&) by swapping it with your perRoleModel implementation.
2. Updates the webui to handle the new format.
- Ben Mahler
On Feb. 20, 2014, 11:04 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18144/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2014, 11:04 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-692 and MESOS-990
> https://issues.apache.org/jira/browse/MESOS-692
> https://issues.apache.org/jira/browse/MESOS-990
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> src/Makefile.am e02d416e5cb8edf6c44ed05c5785a5084bf02abb
> src/common/http.hpp PRE-CREATION
> src/common/http.cpp PRE-CREATION
> src/master/http.cpp c9412749baeb88e8fc270eeca8710f04da2ac076
> src/slave/http.cpp 7c4cfba6676124926cfaa665df9fccf68c7dc187
>
> Diff: https://reviews.apache.org/r/18144/diff/
>
>
> Testing
> -------
>
> make check.
>
> ran master/slave and checked http://localhost:5050/master/state.json by eye.
>
> ran local/python test framework and watched webui main, framework, and slave pages.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 18144: Updated resource model reporting to respect
multiple roles.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18144/#review35178
-----------------------------------------------------------
Ship it!
I will get this committed once you fix the new lines. Thanks for your patience.
src/common/http.cpp
<https://reviews.apache.org/r/18144/#comment65604>
new line.
src/common/http.cpp
<https://reviews.apache.org/r/18144/#comment65605>
new line.
- Vinod Kone
On Feb. 21, 2014, 4:36 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18144/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2014, 4:36 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-692 and MESOS-990
> https://issues.apache.org/jira/browse/MESOS-692
> https://issues.apache.org/jira/browse/MESOS-990
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> src/Makefile.am e02d416e5cb8edf6c44ed05c5785a5084bf02abb
> src/common/http.hpp PRE-CREATION
> src/common/http.cpp PRE-CREATION
> src/master/http.cpp c9412749baeb88e8fc270eeca8710f04da2ac076
> src/slave/http.cpp 7c4cfba6676124926cfaa665df9fccf68c7dc187
>
> Diff: https://reviews.apache.org/r/18144/diff/
>
>
> Testing
> -------
>
> make check.
>
> ran master/slave and checked http://localhost:5050/master/state.json by eye.
>
> ran local/python test framework and watched webui main, framework, and slave pages.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 18144: Updated resource model reporting to respect
multiple roles.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18144/
-----------------------------------------------------------
(Updated Feb. 21, 2014, 1:40 p.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Bugs: MESOS-692 and MESOS-990
https://issues.apache.org/jira/browse/MESOS-692
https://issues.apache.org/jira/browse/MESOS-990
Repository: mesos-git
Description
-------
See summary
Diffs (updated)
-----
src/Makefile.am e02d416e5cb8edf6c44ed05c5785a5084bf02abb
src/common/http.hpp PRE-CREATION
src/common/http.cpp PRE-CREATION
src/master/http.cpp c9412749baeb88e8fc270eeca8710f04da2ac076
src/slave/http.cpp 7c4cfba6676124926cfaa665df9fccf68c7dc187
Diff: https://reviews.apache.org/r/18144/diff/
Testing
-------
make check.
ran master/slave and checked http://localhost:5050/master/state.json by eye.
ran local/python test framework and watched webui main, framework, and slave pages.
Thanks,
Dominic Hamon
Re: Review Request 18144: Updated resource model reporting to respect
multiple roles.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18144/
-----------------------------------------------------------
(Updated Feb. 21, 2014, 8:36 a.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Bugs: MESOS-692 and MESOS-990
https://issues.apache.org/jira/browse/MESOS-692
https://issues.apache.org/jira/browse/MESOS-990
Repository: mesos-git
Description
-------
See summary
Diffs (updated)
-----
src/Makefile.am e02d416e5cb8edf6c44ed05c5785a5084bf02abb
src/common/http.hpp PRE-CREATION
src/common/http.cpp PRE-CREATION
src/master/http.cpp c9412749baeb88e8fc270eeca8710f04da2ac076
src/slave/http.cpp 7c4cfba6676124926cfaa665df9fccf68c7dc187
Diff: https://reviews.apache.org/r/18144/diff/
Testing
-------
make check.
ran master/slave and checked http://localhost:5050/master/state.json by eye.
ran local/python test framework and watched webui main, framework, and slave pages.
Thanks,
Dominic Hamon
Re: Review Request 18144: Updated resource model reporting to respect
multiple roles.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18144/#review35124
-----------------------------------------------------------
Ship it!
Ok great!
src/common/http.cpp
<https://reviews.apache.org/r/18144/#comment65535>
Let's avoid committing commented out code, since we have the history in ReviewBoard and your local git repository has the code in its history as well.
- Ben Mahler
On Feb. 21, 2014, 12:29 a.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18144/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2014, 12:29 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-692 and MESOS-990
> https://issues.apache.org/jira/browse/MESOS-692
> https://issues.apache.org/jira/browse/MESOS-990
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> src/Makefile.am e02d416e5cb8edf6c44ed05c5785a5084bf02abb
> src/common/http.hpp PRE-CREATION
> src/common/http.cpp PRE-CREATION
> src/master/http.cpp c9412749baeb88e8fc270eeca8710f04da2ac076
> src/slave/http.cpp 7c4cfba6676124926cfaa665df9fccf68c7dc187
>
> Diff: https://reviews.apache.org/r/18144/diff/
>
>
> Testing
> -------
>
> make check.
>
> ran master/slave and checked http://localhost:5050/master/state.json by eye.
>
> ran local/python test framework and watched webui main, framework, and slave pages.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 18144: Updated resource model reporting to respect
multiple roles.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18144/
-----------------------------------------------------------
(Updated Feb. 20, 2014, 4:29 p.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Bugs: MESOS-692 and MESOS-990
https://issues.apache.org/jira/browse/MESOS-692
https://issues.apache.org/jira/browse/MESOS-990
Repository: mesos-git
Description
-------
See summary
Diffs (updated)
-----
src/Makefile.am e02d416e5cb8edf6c44ed05c5785a5084bf02abb
src/common/http.hpp PRE-CREATION
src/common/http.cpp PRE-CREATION
src/master/http.cpp c9412749baeb88e8fc270eeca8710f04da2ac076
src/slave/http.cpp 7c4cfba6676124926cfaa665df9fccf68c7dc187
Diff: https://reviews.apache.org/r/18144/diff/
Testing
-------
make check.
ran master/slave and checked http://localhost:5050/master/state.json by eye.
ran local/python test framework and watched webui main, framework, and slave pages.
Thanks,
Dominic Hamon
Re: Review Request 18144: Updated resource model reporting to respect
multiple roles.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18144/
-----------------------------------------------------------
(Updated Feb. 20, 2014, 4:29 p.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Bugs: MESOS-692 and MESOS-990
https://issues.apache.org/jira/browse/MESOS-692
https://issues.apache.org/jira/browse/MESOS-990
Repository: mesos-git
Description
-------
See summary
Diffs (updated)
-----
src/Makefile.am e02d416e5cb8edf6c44ed05c5785a5084bf02abb
src/common/http.hpp PRE-CREATION
src/common/http.cpp PRE-CREATION
src/master/http.cpp c9412749baeb88e8fc270eeca8710f04da2ac076
src/slave/http.cpp 7c4cfba6676124926cfaa665df9fccf68c7dc187
Diff: https://reviews.apache.org/r/18144/diff/
Testing
-------
make check.
ran master/slave and checked http://localhost:5050/master/state.json by eye.
ran local/python test framework and watched webui main, framework, and slave pages.
Thanks,
Dominic Hamon
Re: Review Request 18144: Updated resource model reporting to respect
multiple roles.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18144/
-----------------------------------------------------------
(Updated Feb. 20, 2014, 3:04 p.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Bugs: MESOS-692 and MESOS-990
https://issues.apache.org/jira/browse/MESOS-692
https://issues.apache.org/jira/browse/MESOS-990
Repository: mesos-git
Description
-------
See summary
Diffs (updated)
-----
src/Makefile.am e02d416e5cb8edf6c44ed05c5785a5084bf02abb
src/common/http.hpp PRE-CREATION
src/common/http.cpp PRE-CREATION
src/master/http.cpp c9412749baeb88e8fc270eeca8710f04da2ac076
src/slave/http.cpp 7c4cfba6676124926cfaa665df9fccf68c7dc187
Diff: https://reviews.apache.org/r/18144/diff/
Testing
-------
make check.
ran master/slave and checked http://localhost:5050/master/state.json by eye.
ran local/python test framework and watched webui main, framework, and slave pages.
Thanks,
Dominic Hamon
Re: Review Request 18144: Updated resource model reporting to respect
multiple roles.
Posted by Ben Mahler <be...@gmail.com>.
> On Feb. 20, 2014, 10:06 p.m., Ben Mahler wrote:
> > src/common/http.cpp, line 83
> > <https://reviews.apache.org/r/18144/diff/12/?file=499423#file499423line83>
> >
> > Can you add 'ports' as well? (Sorry I missed this earlier).
> >
> > One downside to explicitly grabbing things like 'cpus', 'disk', 'mem', 'ports' from 'Resources' is that we'll only be exposing these "grandfathered" resources. However, Resources are free-form and operators can expose any additional resources, like 'users', 'disk_io', 'databases', etc. Currently, the perRoleModel() will capture these but the model() function will omit them. Not a big deal, but would be great to either fix or have a TODO about this!
>
> Dominic Hamon wrote:
> Given the webui only currently expects the grandfathered resources to exist, I don't think this is a problem at all.
>
> When we make perRoleModel the default (as per the TODO) then this won't be a concern at all.
Sounds good! Just keep in mind the endpoints were not intended only for the webui so we need to be careful when changing them. As the project grows, users may become increasingly reliant on the JSON format.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18144/#review35084
-----------------------------------------------------------
On Feb. 20, 2014, 11:04 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18144/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2014, 11:04 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-692 and MESOS-990
> https://issues.apache.org/jira/browse/MESOS-692
> https://issues.apache.org/jira/browse/MESOS-990
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> src/Makefile.am e02d416e5cb8edf6c44ed05c5785a5084bf02abb
> src/common/http.hpp PRE-CREATION
> src/common/http.cpp PRE-CREATION
> src/master/http.cpp c9412749baeb88e8fc270eeca8710f04da2ac076
> src/slave/http.cpp 7c4cfba6676124926cfaa665df9fccf68c7dc187
>
> Diff: https://reviews.apache.org/r/18144/diff/
>
>
> Testing
> -------
>
> make check.
>
> ran master/slave and checked http://localhost:5050/master/state.json by eye.
>
> ran local/python test framework and watched webui main, framework, and slave pages.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 18144: Updated resource model reporting to respect
multiple roles.
Posted by Dominic Hamon <dh...@twopensource.com>.
> On Feb. 20, 2014, 2:06 p.m., Ben Mahler wrote:
> > src/common/http.cpp, line 83
> > <https://reviews.apache.org/r/18144/diff/12/?file=499423#file499423line83>
> >
> > Can you add 'ports' as well? (Sorry I missed this earlier).
> >
> > One downside to explicitly grabbing things like 'cpus', 'disk', 'mem', 'ports' from 'Resources' is that we'll only be exposing these "grandfathered" resources. However, Resources are free-form and operators can expose any additional resources, like 'users', 'disk_io', 'databases', etc. Currently, the perRoleModel() will capture these but the model() function will omit them. Not a big deal, but would be great to either fix or have a TODO about this!
Given the webui only currently expects the grandfathered resources to exist, I don't think this is a problem at all.
When we make perRoleModel the default (as per the TODO) then this won't be a concern at all.
- Dominic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18144/#review35084
-----------------------------------------------------------
On Feb. 20, 2014, 1:50 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18144/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2014, 1:50 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-692 and MESOS-990
> https://issues.apache.org/jira/browse/MESOS-692
> https://issues.apache.org/jira/browse/MESOS-990
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> src/Makefile.am e02d416e5cb8edf6c44ed05c5785a5084bf02abb
> src/common/http.hpp PRE-CREATION
> src/common/http.cpp PRE-CREATION
> src/master/http.cpp c9412749baeb88e8fc270eeca8710f04da2ac076
> src/slave/http.cpp 7c4cfba6676124926cfaa665df9fccf68c7dc187
>
> Diff: https://reviews.apache.org/r/18144/diff/
>
>
> Testing
> -------
>
> make check.
>
> ran master/slave and checked http://localhost:5050/master/state.json by eye.
>
> ran local/python test framework and watched webui main, framework, and slave pages.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 18144: Updated resource model reporting to respect
multiple roles.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18144/#review35084
-----------------------------------------------------------
Ship it!
Looks great! Just one thing I missed before in the resource modeling.
src/common/http.cpp
<https://reviews.apache.org/r/18144/#comment65479>
Can you add 'ports' as well? (Sorry I missed this earlier).
One downside to explicitly grabbing things like 'cpus', 'disk', 'mem', 'ports' from 'Resources' is that we'll only be exposing these "grandfathered" resources. However, Resources are free-form and operators can expose any additional resources, like 'users', 'disk_io', 'databases', etc. Currently, the perRoleModel() will capture these but the model() function will omit them. Not a big deal, but would be great to either fix or have a TODO about this!
- Ben Mahler
On Feb. 20, 2014, 9:50 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18144/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2014, 9:50 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-692 and MESOS-990
> https://issues.apache.org/jira/browse/MESOS-692
> https://issues.apache.org/jira/browse/MESOS-990
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> src/Makefile.am e02d416e5cb8edf6c44ed05c5785a5084bf02abb
> src/common/http.hpp PRE-CREATION
> src/common/http.cpp PRE-CREATION
> src/master/http.cpp c9412749baeb88e8fc270eeca8710f04da2ac076
> src/slave/http.cpp 7c4cfba6676124926cfaa665df9fccf68c7dc187
>
> Diff: https://reviews.apache.org/r/18144/diff/
>
>
> Testing
> -------
>
> make check.
>
> ran master/slave and checked http://localhost:5050/master/state.json by eye.
>
> ran local/python test framework and watched webui main, framework, and slave pages.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 18144: Updated resource model reporting to respect
multiple roles.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18144/
-----------------------------------------------------------
(Updated Feb. 20, 2014, 1:50 p.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Bugs: MESOS-692 and MESOS-990
https://issues.apache.org/jira/browse/MESOS-692
https://issues.apache.org/jira/browse/MESOS-990
Repository: mesos-git
Description
-------
See summary
Diffs (updated)
-----
src/Makefile.am e02d416e5cb8edf6c44ed05c5785a5084bf02abb
src/common/http.hpp PRE-CREATION
src/common/http.cpp PRE-CREATION
src/master/http.cpp c9412749baeb88e8fc270eeca8710f04da2ac076
src/slave/http.cpp 7c4cfba6676124926cfaa665df9fccf68c7dc187
Diff: https://reviews.apache.org/r/18144/diff/
Testing
-------
make check.
ran master/slave and checked http://localhost:5050/master/state.json by eye.
ran local/python test framework and watched webui main, framework, and slave pages.
Thanks,
Dominic Hamon
Re: Review Request 18144: Updated resource model reporting to respect
multiple roles.
Posted by Ben Mahler <be...@gmail.com>.
> On Feb. 20, 2014, 9:07 p.m., Ben Mahler wrote:
> >
Oh whoops, raced with Vinod's review, sorry about that!
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18144/#review35066
-----------------------------------------------------------
On Feb. 20, 2014, 9:07 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18144/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2014, 9:07 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-692 and MESOS-990
> https://issues.apache.org/jira/browse/MESOS-692
> https://issues.apache.org/jira/browse/MESOS-990
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> src/Makefile.am e02d416e5cb8edf6c44ed05c5785a5084bf02abb
> src/common/http.hpp PRE-CREATION
> src/common/http.cpp PRE-CREATION
> src/master/http.cpp c9412749baeb88e8fc270eeca8710f04da2ac076
> src/slave/http.cpp 7c4cfba6676124926cfaa665df9fccf68c7dc187
>
> Diff: https://reviews.apache.org/r/18144/diff/
>
>
> Testing
> -------
>
> make check.
>
> ran master/slave and checked http://localhost:5050/master/state.json by eye.
>
> ran local/python test framework and watched webui main, framework, and slave pages.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 18144: Updated resource model reporting to respect
multiple roles.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18144/#review35066
-----------------------------------------------------------
src/common/http.cpp
<https://reviews.apache.org/r/18144/#comment65454>
Why not just: s/optionCpu/cpus/
src/common/http.cpp
<https://reviews.apache.org/r/18144/#comment65455>
Can you add a newline in between these blocks?
cpus = ...;
if (...) {
}
mem = ...;
if (...) {
}
I hope this doesn't seem arbitrary, we'll usually use whitespace between logical blocks of code (although there aren't exactly hard rules here! :)
s/optionMem/mem/
src/common/http.cpp
<https://reviews.apache.org/r/18144/#comment65456>
s/optionDisk/disk/
- Ben Mahler
On Feb. 20, 2014, 9:07 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18144/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2014, 9:07 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-692 and MESOS-990
> https://issues.apache.org/jira/browse/MESOS-692
> https://issues.apache.org/jira/browse/MESOS-990
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> src/Makefile.am e02d416e5cb8edf6c44ed05c5785a5084bf02abb
> src/common/http.hpp PRE-CREATION
> src/common/http.cpp PRE-CREATION
> src/master/http.cpp c9412749baeb88e8fc270eeca8710f04da2ac076
> src/slave/http.cpp 7c4cfba6676124926cfaa665df9fccf68c7dc187
>
> Diff: https://reviews.apache.org/r/18144/diff/
>
>
> Testing
> -------
>
> make check.
>
> ran master/slave and checked http://localhost:5050/master/state.json by eye.
>
> ran local/python test framework and watched webui main, framework, and slave pages.
>
>
> Thanks,
>
> Dominic Hamon
>
>