[jira] Commented: (SHINDIG-297) Split non-servlet parts of the JsServlet out

["Kevin Brown (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SHINDIG-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598825#action_12598825 ] 

Kevin Brown commented on SHINDIG-297:
-------------------------------------

This is a generally useful pattern that I've been applying to the other servlets as well. Servlets are even more annoying because their integration options with Guice is poor. I'm a big fan of moving as much code out of the main servlet and into separate handlers as possible. The style also doesn't really match the rest of the code base. 

I also can't apply this one with patch. :)

> Split non-servlet parts of the JsServlet out
> --------------------------------------------
>
>                 Key: SHINDIG-297
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-297
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Common Components (Java)
>            Reporter: Henning Schmiedehausen
>         Attachments: jsserver.patch
>
>
> Over here, we are using parts of the Shindig code base not through servlets but by other means (using RESTlets, to be exact). Some functionality of Shindig is inside the Servlets and this is hard to use if you don't actually have a servlet container to deploy these to. 
> The attached patch splits the JsServlet into two parts, JsServlet keeps all the functionality that is servlet specfic and everything else gets moved into JsServer, which contains the Shindig/Javascript specific code. JsServer then gets injected by Guice into the Servlet. 
> This patch assumes that SHINDIG-294 and SHINDIG-296 are applied. 
> the patch applies to the current trunk directory with "-p2"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.