You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/08/28 23:47:14 UTC
[kudu-CR] [scripts] updated wire protocol-test results pattern
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14160
Change subject: [scripts] updated wire_protocol-test results pattern
......................................................................
[scripts] updated wire_protocol-test results pattern
Fixed pattern for extracting benchmark results of the wire_protocol-test
in benchmark.sh.
This is a follow-up to 7116a0841ca4dcd62d3e6338cfbd6672df86770a.
Change-Id: I648414979f97c97740f792606f4e04fe611a8076
---
M src/kudu/scripts/benchmarks.sh
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/14160/1
--
To view, visit http://gerrit.cloudera.org:8080/14160
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I648414979f97c97740f792606f4e04fe611a8076
Gerrit-Change-Number: 14160
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [scripts] updated wire protocol-test results pattern
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14160 )
Change subject: [scripts] updated wire_protocol-test results pattern
......................................................................
[scripts] updated wire_protocol-test results pattern
Fixed pattern for extracting benchmark results of the wire_protocol-test
in benchmark.sh.
This is a follow-up to 7116a0841ca4dcd62d3e6338cfbd6672df86770a.
Change-Id: I648414979f97c97740f792606f4e04fe611a8076
Reviewed-on: http://gerrit.cloudera.org:8080/14160
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/scripts/benchmarks.sh
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14160
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I648414979f97c97740f792606f4e04fe611a8076
Gerrit-Change-Number: 14160
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [scripts] updated wire protocol-test results pattern
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14160 )
Change subject: [scripts] updated wire_protocol-test results pattern
......................................................................
Patch Set 1: Code-Review+2
Did you test this manually?
--
To view, visit http://gerrit.cloudera.org:8080/14160
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I648414979f97c97740f792606f4e04fe611a8076
Gerrit-Change-Number: 14160
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 28 Aug 2019 23:56:45 +0000
Gerrit-HasComments: No
[kudu-CR] [scripts] updated wire protocol-test results pattern
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14160 )
Change subject: [scripts] updated wire_protocol-test results pattern
......................................................................
Patch Set 1:
> Did you test this manually?
Yes, I did:
dhcp-10-16-1-116:bench-logs$ /bin/sh do.sh WireProtocolBenchmark*.log
7.50341249
dhcp-10-16-1-116:bench-logs$ for i in `ls WireProtocolBenchmark*`; do /bin/sh do.sh $i; done
7.50341249
7.52187842
7.41382797
7.83984241
7.47444649
7.41662081
7.42355269
7.41837985
7.39584281
7.43238631
dhcp-10-16-1-116:bench-logs$
dhcp-10-16-1-116:bench-logs$ cat do.sh
#!/bin/sh
log=$1
real=`grep "Converting to PB with column count" $log | sed 's|^.*: \([[:digit:].]*\) cycles/cell$|\1|'`
echo $real
--
To view, visit http://gerrit.cloudera.org:8080/14160
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I648414979f97c97740f792606f4e04fe611a8076
Gerrit-Change-Number: 14160
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 29 Aug 2019 00:05:25 +0000
Gerrit-HasComments: No