You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by "rimashah25 (via GitHub)" <gi...@apache.org> on 2023/08/23 20:17:02 UTC
[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7734: Fixed Profiles(APIv5) REST calls to respond with RFC3339 timestamp
rimashah25 commented on code in PR #7734:
URL: https://github.com/apache/trafficcontrol/pull/7734#discussion_r1303498850
##########
lib/go-tc/profiles.go:
##########
@@ -91,6 +92,28 @@ type Profile struct {
Parameters []ParameterNullable `json:"params,omitempty"`
}
+// ProfilesResponseV5 is a list of profiles returned by GET requests.
+type ProfilesResponseV5 struct {
+ Response []ProfileV5 `json:"response"`
+ Alerts
+}
+
+// A ProfileV5 represents a set of configuration for a server or Delivery Service
+// which may be reused to allow sharing configuration across the objects to
+// which it is assigned. Note: Field LastUpdated represents RFC3339
+type ProfileV5 struct {
+ ID int `json:"id" db:"id"`
+ LastUpdated time.Time `json:"lastUpdated" db:"last_updated"`
+ Name string `json:"name" db:"name"`
+ Parameter string `json:"param"`
Review Comment:
A whole bunch of test cases.. But great question to ask.. I had it removed and then I saw massive failures in tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org