You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@struts.apache.org by je...@apache.org on 2008/04/25 10:40:17 UTC

svn commit: r651537 - /struts/struts2/trunk/core/src/main/java/org/apache/struts2/components/template/FreemarkerTemplateEngine.java

Author: jeromy
Date: Fri Apr 25 01:40:10 2008
New Revision: 651537

URL: http://svn.apache.org/viewvc?rev=651537&view=rev
Log:
Added more descriptive LOG.error msg for a missing freemarker template

WW-2615

Modified:
    struts/struts2/trunk/core/src/main/java/org/apache/struts2/components/template/FreemarkerTemplateEngine.java

Modified: struts/struts2/trunk/core/src/main/java/org/apache/struts2/components/template/FreemarkerTemplateEngine.java
URL: http://svn.apache.org/viewvc/struts/struts2/trunk/core/src/main/java/org/apache/struts2/components/template/FreemarkerTemplateEngine.java?rev=651537&r1=651536&r2=651537&view=diff
==============================================================================
--- struts/struts2/trunk/core/src/main/java/org/apache/struts2/components/template/FreemarkerTemplateEngine.java (original)
+++ struts/struts2/trunk/core/src/main/java/org/apache/struts2/components/template/FreemarkerTemplateEngine.java Fri Apr 25 01:40:10 2008
@@ -127,7 +127,18 @@
         }
 
         if (template == null) {
-            LOG.error("Could not load template " + templateContext.getTemplate());
+            if (LOG.isErrorEnabled()) {
+                LOG.error("Could not load the FreeMarker template named '" + templateContext.getTemplate().getName() +"':");
+                for (Template t : templates) {
+                    LOG.error("Attempted: " + getFinalTemplateName(t));
+                }
+                LOG.error("The TemplateLoader provided by the FreeMarker Configuration was a: "+config.getTemplateLoader().getClass().getName());
+                if (freemarkerCaching) {
+                    LOG.error("FreeMarker Template caching is enabled ("+StrutsConstants.STRUTS_FREEMARKER_TEMPLATES_CACHE+"=true) and this template is now cached as missing (the TemplateLoader won't be asked again)");
+                } else {
+                    LOG.error("FreeMarker Template caching is disabled ("+StrutsConstants.STRUTS_FREEMARKER_TEMPLATES_CACHE+"=false)");
+                }
+            }
             if (exception != null) {
                 throw exception;
             } else {