You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@apr.apache.org by sf...@apache.org on 2010/07/28 22:30:52 UTC
svn commit: r980197 - /apr/apr/trunk/dbm/apr_dbm_sdbm.c
Author: sf
Date: Wed Jul 28 20:30:52 2010
New Revision: 980197
URL: http://svn.apache.org/viewvc?rev=980197&view=rev
Log:
For now, revert part of r979891 to fix test breakage. But the error handling
of apr_sdbm_nextkey seems broken.
Modified:
apr/apr/trunk/dbm/apr_dbm_sdbm.c
Modified: apr/apr/trunk/dbm/apr_dbm_sdbm.c
URL: http://svn.apache.org/viewvc/apr/apr/trunk/dbm/apr_dbm_sdbm.c?rev=980197&r1=980196&r2=980197&view=diff
==============================================================================
--- apr/apr/trunk/dbm/apr_dbm_sdbm.c (original)
+++ apr/apr/trunk/dbm/apr_dbm_sdbm.c Wed Jul 28 20:30:52 2010
@@ -192,8 +192,11 @@ static apr_status_t vt_sdbm_nextkey(apr_
pkey->dptr = rd.dptr;
pkey->dsize = rd.dsize;
- /* store any error info into DBM, and return a status code. */
- return set_error(dbm, rv);
+ /*
+ * XXX: This discards any error but apr_sdbm_nextkey currently returns
+ * XXX: an error for the last key
+ */
+ return set_error(dbm, APR_SUCCESS);
}
static void vt_sdbm_freedatum(apr_dbm_t *dbm, apr_datum_t data)