You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ms...@apache.org on 2020/11/13 19:50:56 UTC

svn commit: r1883400 - in /pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form: PDButton.java PDPushButton.java PDRadioButton.java

Author: msahyoun
Date: Fri Nov 13 19:50:56 2020
New Revision: 1883400

URL: http://svn.apache.org/viewvc?rev=1883400&view=rev
Log:
PDFBOX-5016: deprecate setting the subtype from PDButton

Modified:
    pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDButton.java
    pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDPushButton.java
    pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDRadioButton.java

Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDButton.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDButton.java?rev=1883400&r1=1883399&r2=1883400&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDButton.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDButton.java Fri Nov 13 19:50:56 2020
@@ -94,8 +94,10 @@ public abstract class PDButton extends P
     /**
      * Set the push button bit.
      *
+     * @deprecated use {@link org.apache.pdfbox.pdmodel.interactive.form.PDPushButton} instead
      * @param pushbutton if true the button field is treated as a push button field.
      */
+    @Deprecated
     public void setPushButton(boolean pushbutton)
     {
         getCOSObject().setFlag(COSName.FF, FLAG_PUSHBUTTON, pushbutton);
@@ -118,8 +120,10 @@ public abstract class PDButton extends P
     /**
      * Set the radio button bit.
      *
+     * @deprecated use {@link org.apache.pdfbox.pdmodel.interactive.form.PDRadioButton} instead
      * @param radiobutton if true the button field is treated as a radio button field.
      */
+    @Deprecated
     public void setRadioButton(boolean radiobutton)
     {
         getCOSObject().setFlag(COSName.FF, FLAG_RADIO, radiobutton);

Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDPushButton.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDPushButton.java?rev=1883400&r1=1883399&r2=1883400&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDPushButton.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDPushButton.java Fri Nov 13 19:50:56 2020
@@ -22,6 +22,7 @@ import java.util.List;
 import java.util.Set;
 
 import org.apache.pdfbox.cos.COSDictionary;
+import org.apache.pdfbox.cos.COSName;
 
 /**
  * A pushbutton is a purely interactive control that responds immediately to user
@@ -39,7 +40,7 @@ public class PDPushButton extends PDButt
     public PDPushButton(PDAcroForm acroForm)
     {
         super(acroForm);
-        setPushButton(true);
+        getCOSObject().setFlag(COSName.FF, FLAG_PUSHBUTTON, true);
     }
     
     /**

Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDRadioButton.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDRadioButton.java?rev=1883400&r1=1883399&r2=1883400&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDRadioButton.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDRadioButton.java Fri Nov 13 19:50:56 2020
@@ -44,7 +44,7 @@ public final class PDRadioButton extends
     public PDRadioButton(PDAcroForm acroForm)
     {
         super(acroForm);
-        setRadioButton(true);
+        getCOSObject().setFlag(COSName.FF, FLAG_RADIO, true);
     }
     
     /**