[GitHub] [metron] nickwallen commented on a change in pull request #1554: METRON-2307: Migrate to JUnit5

[GitBox <gi...@apache.org>]

nickwallen commented on a change in pull request #1554: METRON-2307: Migrate to JUnit5
URL: https://github.com/apache/metron/pull/1554#discussion_r346890961
 
 

 ##########
 File path: metron-stellar/stellar-common/pom.xml
 ##########
 @@ -230,11 +230,29 @@
             <version>${global_httpclient_version}</version>
         </dependency>
         <dependency>
-            <!-- junit dependency added with default scope to allow inclusion of StellarProcessorUtils in main jar.
-                 It is excluded from the uber-jar. -->
-            <groupId>junit</groupId>
-            <artifactId>junit</artifactId>
-            <version>${global_junit_version}</version>
+            <groupId>org.hamcrest</groupId>
+            <artifactId>hamcrest-core</artifactId>
+            <version>${global_hamcrest_version}</version>
+            <scope>test</scope>
+        </dependency>
+        <!-- junit dependency added with default scope to allow inclusion of StellarProcessorUtils in main jar.
+             It is excluded from the uber-jar. -->
+        <dependency>
 
 Review comment:
   I agree with you @justinleet .  It doesn't make sense to use JUnit assertions in non-test code like `ensureKryoSerializable` and `ensureJavaSerializable`. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services