You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by mo...@apache.org on 2016/12/03 15:42:44 UTC

zeppelin git commit: [ZEPPELIN-1742] send error info to popup when commit fails

Repository: zeppelin
Updated Branches:
  refs/heads/master 0d65dabf3 -> da1e8763e


[ZEPPELIN-1742] send error info to popup when commit fails

### What is this PR for?
To notify user when commit of note revision have failed.

### What type of PR is it?
Bug Fix | Improvement

### Todos
* [x] - send error

### What is the Jira issue?
[ZEPPELIN-1742](https://issues.apache.org/jira/browse/ZEPPELIN-1742)

### How should this be tested?
try to commit note with default storage

### Screenshots (if appropriate)
failure case before:
![commit error before](https://cloud.githubusercontent.com/assets/1642088/20796541/e91c3d76-b819-11e6-9d73-aaa6708b8a2d.gif)

failure case after:
![commit error](https://cloud.githubusercontent.com/assets/1642088/20796103/faf4c33a-b817-11e6-849a-75401a96b6cb.gif)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: Khalid Huseynov <kh...@gmail.com>

Closes #1712 from khalidhuseynov/feat/commit-error-popup and squashes the following commits:

dc02960 [Khalid Huseynov] send error info popup


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/da1e8763
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/da1e8763
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/da1e8763

Branch: refs/heads/master
Commit: da1e8763e03915b5358e122a2bdd5805b5c2510b
Parents: 0d65dab
Author: Khalid Huseynov <kh...@gmail.com>
Authored: Thu Dec 1 22:20:18 2016 +0900
Committer: Lee moon soo <mo...@apache.org>
Committed: Sat Dec 3 07:42:38 2016 -0800

----------------------------------------------------------------------
 .../src/main/java/org/apache/zeppelin/socket/NotebookServer.java | 4 ++++
 1 file changed, 4 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/da1e8763/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
----------------------------------------------------------------------
diff --git a/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java b/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
index ef11cef..7310b20 100644
--- a/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
+++ b/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
@@ -1401,6 +1401,10 @@ public class NotebookServer extends WebSocketServlet implements
       List<Revision> revisions = notebook.listRevisionHistory(noteId, subject);
       conn.send(serializeMessage(new Message(OP.LIST_REVISION_HISTORY)
         .put("revisionList", revisions)));
+    } else {
+      conn.send(serializeMessage(new Message(OP.ERROR_INFO).put("info",
+          "Couldn't checkpoint note revision: possibly storage doesn't support versioning. "
+          + "Please check the logs for more details.")));
     }
   }