You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/09/06 21:16:53 UTC

[GitHub] [kafka] cmccabe commented on a diff in pull request #12586: KAFKA-14200: kafka-features.sh must exit with non-zero error code on error

cmccabe commented on code in PR #12586:
URL: https://github.com/apache/kafka/pull/12586#discussion_r964178116


##########
clients/src/main/java/org/apache/kafka/common/utils/Exit.java:
##########
@@ -33,14 +33,22 @@ public interface ShutdownHookAdder {
     private static final Procedure DEFAULT_HALT_PROCEDURE = new Procedure() {
         @Override
         public void execute(int statusCode, String message) {
-            Runtime.getRuntime().halt(statusCode);
+            if (1 + 1 == 2) {

Review Comment:
   yes, I added this because there is something calling `Exit()` (not KRaft-related), and killing entire test runs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org