You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/11/30 17:33:12 UTC
[GitHub] [flink] TisonKun commented on a change in pull request #10370:
[FLINK-14947] Introduce LocalExecutor and make Local(Stream)Environment use
it
TisonKun commented on a change in pull request #10370: [FLINK-14947] Introduce LocalExecutor and make Local(Stream)Environment use it
URL: https://github.com/apache/flink/pull/10370#discussion_r352295512
##########
File path: flink-core/src/main/java/org/apache/flink/api/common/PlanExecutor.java
##########
@@ -129,16 +110,16 @@ public static PlanExecutor createRemoteExecutor(
}
}
- private static Class<? extends PlanExecutor> loadExecutorClass(String className) {
Review comment:
I don't think we should modify this method in this pass. `loadExecutorClass` implicitly load remote executor makes non-sense. We can remote the whole `PlanExecutor` when we later get rid of `RemoteExecutor extends PlanExecutor`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services