You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/03/19 17:19:21 UTC

[GitHub] [couchdb] chewbranca commented on pull request #3416: Prometheus endpoint

chewbranca commented on pull request #3416:
URL: https://github.com/apache/couchdb/pull/3416#issuecomment-802988940


   Does this need to be a stateful application? Rather than having a dedicated app hierarchy here, can we just add a `_prometheus` endpoint to https://github.com/apache/couchdb/blob/main/src/chttpd/src/chttpd_node.erl#L121-L124 
   
   that then does the conversion over https://github.com/apache/couchdb/blob/main/src/chttpd/src/chttpd_node.erl#L206-L236
   
   We could avoid having the server that does the caching and just do it on demand when the request comes in.
   
   I'm also not a huge fan of introducing an additional http server to the mix. Is supporting unauthenticated requests to the Prometheus endpoint a necessary feature?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org